You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Can we consider removing the snippet that drops the enable-alpha and enable-beta flags from e2e-tests.sh script for gateway-api testing?
Context
Currently, tests such as test/conformance/api/v1beta1.TestDomainMapping and a few others tests related to alpha and beta features are currently being skipped in Prow, as observed in gateway-api-contour and gateway-api-istio. This skipping appears to be due to the removal of enable-alpha and enable-beta flags for gateway-api in the e2e-tests.sh script here:
# Drop testing alpha and beta features with the Gateway API
if [[ "${INGRESS_CLASS}"!=*"gateway-api"* ]];then
E2E_TEST_FLAGS+=" -enable-alpha -enable-beta"
fi
fi
However, some tests that run in Kind (GitHub Actions) don't use the e2e-tests.sh script to run the tests and explicitly set the above-mentioned flags, resulting in successful test execution.
Important to note that in Kind, we only run end-to-end tests, not conformance tests. However, some alpha and beta features are successfully tested in Kind. The specific test mentioned in this issue, test/conformance/api/v1beta1.TestDomainMapping, is not run in Kind since it is a conformance test. Nevertheless, it was tested locally and passed.
Hi @izabelacg, @dprotaso removed the flags here: #14296 maybe the idea was to get all basic tests pass first on prow? Btw I am ok to discover failing stuff upfront.
Question
Can we consider removing the snippet that drops the
enable-alpha
andenable-beta
flags from e2e-tests.sh script for gateway-api testing?Context
Currently, tests such as
test/conformance/api/v1beta1.TestDomainMapping
and a few others tests related to alpha and beta features are currently being skipped in Prow, as observed in gateway-api-contour and gateway-api-istio. This skipping appears to be due to the removal ofenable-alpha
andenable-beta
flags for gateway-api in the e2e-tests.sh script here:serving/test/e2e-tests.sh
Lines 45 to 49 in 40088e3
However, some tests that run in Kind (GitHub Actions) don't use the e2e-tests.sh script to run the tests and explicitly set the above-mentioned flags, resulting in successful test execution.
Important to note that in Kind, we only run end-to-end tests, not conformance tests. However, some alpha and beta features are successfully tested in Kind. The specific test mentioned in this issue, test/conformance/api/v1beta1.TestDomainMapping, is not run in Kind since it is a conformance test. Nevertheless, it was tested locally and passed.
serving/.github/workflows/kind-e2e.yaml
Lines 212 to 221 in 40088e3
Test PR with tests passing in Kind: #15202
The text was updated successfully, but these errors were encountered: