Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/conformance/api/v1beta1.TestDomainMapping is being skipped in Prow but passing in Kind #15203

Open
izabelacg opened this issue May 13, 2024 · 1 comment
Labels
kind/question Further information is requested

Comments

@izabelacg
Copy link
Member

Question

Can we consider removing the snippet that drops the enable-alpha and enable-beta flags from e2e-tests.sh script for gateway-api testing?

Context

Currently, tests such as test/conformance/api/v1beta1.TestDomainMapping and a few others tests related to alpha and beta features are currently being skipped in Prow, as observed in gateway-api-contour and gateway-api-istio. This skipping appears to be due to the removal of enable-alpha and enable-beta flags for gateway-api in the e2e-tests.sh script here:

# Drop testing alpha and beta features with the Gateway API
if [[ "${INGRESS_CLASS}" != *"gateway-api"* ]]; then
E2E_TEST_FLAGS+=" -enable-alpha -enable-beta"
fi
fi

However, some tests that run in Kind (GitHub Actions) don't use the e2e-tests.sh script to run the tests and explicitly set the above-mentioned flags, resulting in successful test execution.

Important to note that in Kind, we only run end-to-end tests, not conformance tests. However, some alpha and beta features are successfully tested in Kind. The specific test mentioned in this issue, test/conformance/api/v1beta1.TestDomainMapping, is not run in Kind since it is a conformance test. Nevertheless, it was tested locally and passed.

run: |
gotestsum --format testname -- \
-race -count=1 -parallel=1 -tags=e2e \
-timeout=30m \
${{ matrix.test-path }} \
-skip-cleanup-on-fail \
-disable-logstream \
-enable-alpha -enable-beta \
--ingress-class=${{ matrix.ingress-class || matrix.ingress }}.ingress.networking.knative.dev \
${{ matrix.test-flags }}

Test PR with tests passing in Kind: #15202

@izabelacg izabelacg added the kind/question Further information is requested label May 13, 2024
@skonto
Copy link
Contributor

skonto commented May 15, 2024

Hi @izabelacg, @dprotaso removed the flags here: #14296 maybe the idea was to get all basic tests pass first on prow? Btw I am ok to discover failing stuff upfront.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants