Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.30 tag also breaks PodIP.IP (which should be marked required) #124900

Open
tatsuhiro-t opened this issue May 16, 2024 · 3 comments · May be fixed by #124904
Open

1.30 tag also breaks PodIP.IP (which should be marked required) #124900

tatsuhiro-t opened this issue May 16, 2024 · 3 comments · May be fixed by #124904
Labels
kind/bug Categorizes issue or PR as related to a bug. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@tatsuhiro-t
Copy link
Contributor

What happened?

We have a CRD that contains PodStatus. After generating CRD with k8s v1.30.1, applying it failed with the message:

spec.validation.openAPIV3Schema.properties[status].properties[podIPs].items.properties[ip].default: Required value: this property is in x-kubernetes-list-map-keys, so it must have a default or be a required property

Similar issue reported in #124540 but different struct field.

What did you expect to happen?

CRD is applied successfully.

How can we reproduce it (as minimally and precisely as possible)?

Create CRD that has PodStatus and then apply it.

Anything else we need to know?

This is a leftover of #124553
PodIP.IP should also be marked required because it is +listMapKey=ip in PodStatus.PodIPs.

Kubernetes version

$ kubectl version
Client Version: v1.30.0
Kustomize Version: v5.0.4-0.20230601165947-6ce0bf390ce3

Cloud provider

OS version

# On Linux:
$ cat /etc/os-release
# paste output here
$ uname -a
# paste output here

# On Windows:
C:\> wmic os get Caption, Version, BuildNumber, OSArchitecture
# paste output here

Install tools

Container runtime (CRI) and version (if applicable)

Related plugins (CNI, CSI, ...) and versions (if applicable)

@tatsuhiro-t tatsuhiro-t added the kind/bug Categorizes issue or PR as related to a bug. label May 16, 2024
@k8s-ci-robot k8s-ci-robot added needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 16, 2024
@tatsuhiro-t
Copy link
Contributor Author

/sig api-machinery

@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 16, 2024
@liangyuanpeng liangyuanpeng linked a pull request May 16, 2024 that will close this issue
@seans3
Copy link
Contributor

seans3 commented May 21, 2024

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 21, 2024
@Williams23678
Copy link

On Linux:

$ cat /etc/os-release

paste output here

$ uname -a

paste output here

On Windows:

C:> wmic os get Caption, Version, BuildNumber, OSArchitecture

paste output here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants