Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyPI package for ledger.so #1934

Open
aparkerlue opened this issue Jun 21, 2020 · 9 comments · May be fixed by #2246
Open

PyPI package for ledger.so #1934

aparkerlue opened this issue Jun 21, 2020 · 9 comments · May be fixed by #2246
Assignees
Labels
build Build problems python Related to the Python API
Milestone

Comments

@aparkerlue
Copy link

It would be useful to have a PyPI package that provides ledger.so so that Python packages that import ledger could express a dependency on it. Is there currently a PyPI package for obtaining ledger.so?

If not, is there any interest in including the machinery for such a package in the Ledger codebase?

@tbm
Copy link
Contributor

tbm commented Jul 8, 2020

I think it would be interesting if that's possible.

@tbm tbm added the build Build problems label Jul 8, 2020
@afh afh added the python Related to the Python API label Apr 16, 2023
@afh afh added this to the 3.4 milestone Apr 16, 2023
@afh
Copy link
Member

afh commented Apr 16, 2023

@aparkerlue I'm familiarizing myself the the PyPI eco-system in order to be able to provide what you suggest. Prior to that it will be very helpful to have a Python Package with a (binary) core Ledger Module. I'm still roughing things out on this and am at this point uncertain when a PR will be available for tests.

@afh afh self-assigned this Apr 16, 2023
@aparkerlue
Copy link
Author

Sounds good. Please let me know how I can help.

@afh
Copy link
Member

afh commented Apr 17, 2023

Thanks for the offer, @aparkerlue. Do you happen to have expertise in building Python Packages with binary Python Modules by any chance? I'm looking into building a Python wheel using scikit-build-core, scikit-build, cibuildwheel, or other means. For Ledger this means dealing with Boost, Boost Python, and the required dependencies mpfr and gmp as well.
I could also use some help or guidance with structuring projects for the CMake build process.

Currently I have a nix flakes based development setup to work on the scikit-build-core based build pyproject.toml to create an installable Python wheel using pipx.

@afh
Copy link
Member

afh commented Apr 18, 2023

I've made significant progress today and am able to build Ledger as a Python wheel and install that into a venv locally on my workstation. There is still a lot of work to do, especially re-organizing the Python side of things in order to provide a Python Package offering backwards compatibility.

@aparkerlue
Copy link
Author

aparkerlue commented Apr 19, 2023 via email

@afh
Copy link
Member

afh commented Apr 19, 2023

I should have something to share in the coming days, @aparkerlue. Out of curiosity: What is your operating system and python version of choice? And which other operating systems and hardware architecture do you possibly have access to to help out testing?

I'm currently developing on macOS using nixpkgs and have access to OpenBSD.

@aparkerlue
Copy link
Author

aparkerlue commented Apr 19, 2023 via email

@afh afh linked a pull request Apr 20, 2023 that will close this issue
@afh
Copy link
Member

afh commented Apr 20, 2023

@aparkerlue that's very helpful, thanks! #2246 is a draft PR (based on afh/ledger@pypi) with which you should be able to test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Build problems python Related to the Python API
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants