Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanups inside sample are not called, leaking #196

Open
fabiospampinato opened this issue Feb 25, 2022 · 0 comments
Open

Cleanups inside sample are not called, leaking #196

fabiospampinato opened this issue Feb 25, 2022 · 0 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@fabiospampinato
Copy link

In the following Solid code you can see in the console a message gets printed about once every second: https://playground.solidjs.com/?hash=-357212261&version=1.3.7

I don't have the equivalent code for Sinuous, but I'm pretty sure that it won't work right in Sinuous, because by calling sample the tracking object is removed, so cleanups are not registered with anything, so they never get called, so you'll see in Sinuous that there will be 4 intervals running at the same time, because they won't be stopped, while there should be just one, like in Solid.

The solution seems to be that in Solid the tracking object and the tracking object for cleanups aren't necessarily the same object, so while there isn't a regular tracking object inside sample cleanups kind of bubble up until they can find a parent computation that they can attach themselves to.

@luwes luwes added bug Something isn't working help wanted Extra attention is needed labels Sep 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants