Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sinuous/map v0.30.0 removes node unexpectedly. #239

Open
j-sen opened this issue Aug 10, 2023 · 1 comment
Open

sinuous/map v0.30.0 removes node unexpectedly. #239

j-sen opened this issue Aug 10, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@j-sen
Copy link

j-sen commented Aug 10, 2023

When [ "foo", "BAR", "baz" ] is transformed to [ "BAR" ], all elements will be deleted then "BAR" will be recreated.

In version 0.27.6, [ "foo", "BAR", "baz" ] is transformed to [ "BAR" ] by deleting "foo" and "baz", which seems more reasonable.

Here is the code demonstrates this situation. https://codepen.io/j-sen/pen/MWzdBdP

@mindplay-dk
Copy link
Contributor

@luwes remember that infinite thread where I tested every single one of those reconcilers? as I recall, this one did have a problem like this. maybe it's time to replace it?

@j-sen you could look around (try a search for "reconciler" in issues) and see if you can find that very long thread of mine - I tested and benchmarked every algo and found several of them to have problems... as I recall, there was a pretty clear cut winner in terms of file size, performance and correctness, and it wasn't the one being used here.

as I recall @luwes was open to replacing it - and it should be fairly easy to drop in the replacement, but he's also said the project is low priority for him. It seems he's still accepting pull requests though. 🙂

@luwes luwes added the enhancement New feature or request label Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants