Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache control for tiles: max-age=0 is ignored #3784

Open
Schlepptop opened this issue Mar 4, 2024 · 0 comments · May be fixed by #3785
Open

Cache control for tiles: max-age=0 is ignored #3784

Schlepptop opened this issue Mar 4, 2024 · 0 comments · May be fixed by #3785

Comments

@Schlepptop
Copy link

maplibre-gl-js version: 4.0.2

browser: Chrome

Steps to Trigger Behavior

  1. Create a custom scheme that sets the cacheControl to "max-age=0" for every tile.

Link to Demonstration

No

Expected Behavior

Tiles should get an expirationTime of 0

Actual Behavior

Tiles should get an expirationTime of null

I believe this is due to the type-coercion at

maplibre-gl-js/src/source/tile.ts

Line 364 in ee0450c

if (this.expirationTime) {

Schlepptop added a commit to Schlepptop/maplibre-gl-js that referenced this issue Mar 4, 2024
@Schlepptop
Don't skip on expirationTime == 0
7fbec74 
Fixes maplibre#3784
@Schlepptop Schlepptop linked a pull request Mar 4, 2024 that will close this issue
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't skip on expirationTime == 0 Schlepptop/maplibre-gl-js
1 participant
@Schlepptop