Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebVTT thumbs do not work, if the list doesn't start with 00:00.000 #56

Open
mash-graz opened this issue Feb 29, 2020 · 1 comment · May be fixed by vlanard/videoscripts#14
Open

WebVTT thumbs do not work, if the list doesn't start with 00:00.000 #56

mash-graz opened this issue Feb 29, 2020 · 1 comment · May be fixed by vlanard/videoscripts#14

Comments

@mash-graz
Copy link

Describe the bug

if the entries in the .vtt file do not start with 00:00.000, which is unfortunately the default behavior, if you use [makesprites.py] and do not manually set the TIMESYNC_ADJUST constant to -1, Indiego-player will not show any thumbs on the cue/progress-bar.

To Reproduce

just manually modify the first entry of a working .vtt-file and increment the start time

Expected behavior

well -- it's in fact a flaw of another application, but nevertheless it would be nice, if indigo-player could tolerate this kind of vtt-files, because the actual cause for this issue rather hard to debug for most users.

[btw: i have to say, your player is IMHO by far the best available open source video player right now! :) ]
@mash-graz
Copy link
Author

...and it also doesn't like additional cue identifiers (as provided by the WebVTT specification)...

mash-graz pushed a commit to mash-graz/videoscripts that referenced this issue Mar 3, 2020
more useful default settings and eleminating the cue identifierers
5da6cc9 
* the presence of the 'sips' executable is now autodetected to let it
  work out of the box on non-mac machines

* TIMESYNC_ADJUST isn't neccessary on more recent ffmpeg executables.
  if not set to -1 the time stamps will not start with 0:00.000, which
  is not accepted by some applicationes
  (see: matvp91/indigo-player#56)

* explicit cue identifierers in the output don't make much sense and
  also tend to be incompatible. (e.g. in case of indigo-player)
@mash-graz mash-graz linked a pull request Mar 3, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cleanups and compatibility with indigo-player mash-graz/videoscripts
1 participant
@mash-graz