Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio description in a11y not working for external YouTube videos #199

Open
digitas-git opened this issue Jun 15, 2021 · 0 comments
Open

Comments

@digitas-git
Copy link
Collaborator

digitas-git commented Jun 15, 2021

Using the a11y plugin for adding audio description I recognized, that it works fine if I don't use videos rom YouTube. The button for audio description is added but there is no effect clicking it.

It seems that the EventListeners for playing, pausing, timeupdate etc. added to the player.node are working fine for "local" videos, but that for YouTube videos the player.media (that is the wrapper for the iframe tag and the video tag) needs these eventListeners. Changing t.node.addEventListener to t.media.addEventListener makes the plugin work also for YouTube videos. Also the timeupdate event and the volumechange event have to be modified because t.node.currentTime or t.node.volume are unknown for YouTube videos.

I will add a pull request for this and link it here.

Edited:
Pull request is here: #200

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant