Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to include files into the Docker image #2

Open
brendandburns opened this issue Dec 5, 2017 · 3 comments
Open

Add the ability to include files into the Docker image #2

brendandburns opened this issue Dec 5, 2017 · 3 comments

Comments

@brendandburns
Copy link
Contributor

Right now the packaging just packages code. We should extend the annotations to include arbitrary files via a FileSet annotation or somesuch.

@willpenington
Copy link
Contributor

I'd be interested in giving this a go, starting with a Java implentation then porting to the other languages

My initial design would be to add a new tag called something like @PackageFile and a parameter on the package tag that takes an array of them giving something like

public class Main {
    @Package(repository="brendanburns",
             jarFile="path/to/my-fat-jar.jar"),
             additionalFiles={
               @PackageFile(path="/opt/hello/message", src="files/messages"),
               @PackageFile(path="/etc/hello.conf", src="files/default.conf")
             })
    public static void main(String[] args) {
        Containerize(() -> {
            System.out.println("Hello Metaparticle/Package");
        });
    }
}

@brendandburns
Copy link
Contributor Author

@willpenington That design looks great to me.

Thanks!

@wagoodman
Copy link
Contributor

This issue is a bit stale, as long as we're all on the same page about including a additionalFiles mechanism I'll give this a shot with python and we can discuss further on the PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants