-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bunyan logger problems #1321
Comments
@JacksonWeber Sure! Here is where we create the logger...
Here is an example of an "info" level call...
Here is an example of an "error" level call...
|
@skhilliard Thank you for following up. Regarding the changes in Bunyan trace logging, I understand the changes you're referring to now. As a part of our move to OpenTelemetry we also moved away from our previous diagnostic-channel usage to an OpenTelemetry offering for tracking Bunyan, which explains why some fields are not identical here. Does this new data formatting break implementations on your end? I also tested your error implementation, and I'm still seeing the logs being produced from these logging calls. The contained error object is not serialized correctly (this has just been fixed in the exporter and will roll out with the next release), but I'm not seeing issues with generation from the SDK. Are you seeing no traces with |
@JacksonWeber We do have some alerts and other queries that count on the structure of the messages field, so it'd be ideal if it was the same rather than "flattened" as a string. I do have some traces with severity level of 3 but only when I'm not passing in an error object. E.g. |
@skhilliard I don't know that the message field is really "flattened" so much as it just reports the Bunyan's I've tested further and haven't been able to find any type of object/data I can pass to the |
@JacksonWeber Thanks for delving into this! For my testing of the error condition, I just intentionally threw an error using an Error object like this: let error = new Error('fakeError') Kelly |
@JacksonWeber Any updates for this? Thanks! |
@skhilliard Apologies for the delay. I tested your above error with the following code:
And I get a resultant trace that looks like this: Are you ensuring that the test you're using gives ample time to the SDK to export the error logs? If you want to make sure, you can |
@JacksonWeber Yeah....I am sure we were giving enough time for the logs to export. What version of bunyan are you using? We are using...
|
@skhilliard I'm using the same versions of both bunyan and the bunyan-middleware package. I also tested with both application insights 3.0.1 and 3.1.0, and both are behaving the same way for me. Please let me know if my sample app is not representative of your scenario in any way! |
I am attempting to upgrade from 2.x to 3.0.1 and have encountered several issues with the application insights shim. Among them are differences in how our trace/error logging is impacted.
with 2.x we see this form...
enableLoggerErrorToTrace
I didn't expect it to show up in traces, but it does not even show up in exceptions. Here is an example of it showing as a trace using 2.x..again with 3.x no entries are found anywhere when this same error is logged.
The text was updated successfully, but these errors were encountered: