Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Planner] Skip groups selecting step if groups are specified explicitly #322

Open
StpMax opened this issue Nov 9, 2023 · 0 comments
Open
Assignees
Labels
enhancement New feature or request planner

Comments

@StpMax
Copy link
Contributor

StpMax commented Nov 9, 2023

Let assume there are TS model created:

CREATE MODEL 
  mindsdb.house_sales_model
FROM example_db
  (SELECT * FROM demo_data.house_sales)
PREDICT ma
ORDER BY saledate
GROUP BY type
WINDOW 8
HORIZON 4; 

If do JOIN query like this:

 SELECT m.saledate as date, m.ma as forecast
  FROM mindsdb.house_sales_model as m 
  JOIN example_db.demo_data.house_sales as t
  WHERE t.saledate > LATEST AND t.type = 'house';

then fist step will be FetchDataframeStep with query

SELECT DISTINCT t.type AS type FROM demo_data.house_sales AS t WHERE t.type = 'house'

The step is redundant, because initially query already contains filter by type. Will be good to skip this step.

@StpMax StpMax added the enhancement New feature or request label Nov 9, 2023
@ea-rus ea-rus added the planner label Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request planner
Projects
None yet
Development

No branches or pull requests

2 participants