Skip to content
This repository has been archived by the owner on Jun 3, 2020. It is now read-only.

Testing against different versions of Redash #75

Open
jrbenny35 opened this issue Sep 10, 2018 · 3 comments
Open

Testing against different versions of Redash #75

jrbenny35 opened this issue Sep 10, 2018 · 3 comments
Labels
discussion Issues for discussing ideas for features infra Tasks related to Docker/CI etc.

Comments

@jrbenny35
Copy link
Collaborator

So as seen in PR #73, the redash-ui-test suite runs against the latest tag. This time there were some breaking changes introduced in the 5.0 beta that requires some changes to how our tests run. This has made me wonder how we should handle our testing.

We want to keep the upstream tests running but to do that, we need to make sure our tests can run against the current latest as well as the current beta build.

@jrbenny35 jrbenny35 added discussion Issues for discussing ideas for features code quality Tasks related to linting, coding style, type checks labels Sep 10, 2018
@jrbenny35
Copy link
Collaborator Author

Doing some research it seems the docker builds aren't kept quite up to date, and the tag name changes too. We would have to pull current redash master and build a docker image of that to be at the same point as the upstream integration-tests.

@jezdez
Copy link
Contributor

jezdez commented Sep 10, 2018

Hm, that sounds like a good plan of action, being able to test both, the "latest" release that upstream has made, as well as the current "development" version, is definitely a worthwhile goal. 👍

@hackebrot
Copy link
Collaborator

This issue is a duplicate of #6. I'll close the other one as it hasn't seen any comments.

@hackebrot hackebrot added infra Tasks related to Docker/CI etc. and removed code quality Tasks related to linting, coding style, type checks labels Sep 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
discussion Issues for discussing ideas for features infra Tasks related to Docker/CI etc.
Projects
None yet
Development

No branches or pull requests

3 participants