Skip to content
This repository has been archived by the owner on Jun 3, 2020. It is now read-only.

Inaccurate data in report.html file #99

Open
madalincm opened this issue Oct 25, 2018 · 5 comments
Open

Inaccurate data in report.html file #99

madalincm opened this issue Oct 25, 2018 · 5 comments
Assignees
Labels
bug Bugs and problems with redash-ui-tests

Comments

@madalincm
Copy link

Steps to reproduce:

  1. Run the tests and observe the results in the terminal: docker run --net="host" --env REDASH_SERVER_URL=http://127.0.0.1:5000 redash-ui-tests:latest
  2. Copy the report file from the Docker container to your machine: docker cp ui-tests:/home/user/src/report.html ./report.html
  3. Observe the information displayed in the report.html file

Expected results:

The information displayed in the report.html file is accurate. Same number of pass/failed tests is displayed in both terminal and report.html file

Actual results:

After running the tests the following can be seen in terminal:
8 failed, 4 passed, 52 warnings in 88.29 seconds

and in report.html:
0 tests ran in 20.12 seconds. 12 errors

Also the date for the report seems to be wrong: Report generated on 24-Oct-2018 at 16:15:06 by pytest-html v1.19.0 but the tests were run today (25-OCT-2018)

@madalincm madalincm added the bug Bugs and problems with redash-ui-tests label Oct 25, 2018
@jrbenny35
Copy link
Collaborator

I just tried to reproduce this using ubuntu 18.01 and I could not. I got all passing tests. I used the make command make docker-ui-tests and it seems to work.

Can you run me though the steps you took to install docker and the dependencies?

@jrbenny35
Copy link
Collaborator

After doing some digging I think we need to rework our docker-compose. We should add a selenium image and allow that image to mount the local directory. Then we could use a command like docker-compose exec selenium pipenv run pytest and the changes within the image will always be current due to the mount, and we wouldn't have to worry about updating geckodriver/firefox versions.

@jrbenny35 jrbenny35 self-assigned this Nov 21, 2018
@jrbenny35
Copy link
Collaborator

docker run --net="host" --name "redash-ui-tests" --env REDASH_SERVER_URL=http://127.0.0.1:5000 redash-ui-tests:latest

@hackebrot
Copy link
Collaborator

Hey @madalincm @jrbenny35! 👋

What's the status of this bug? Can we close this issue?

@hackebrot
Copy link
Collaborator

Hi @madalincm @jrbenny35! 🙂

Can we close this bug?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Bugs and problems with redash-ui-tests
Projects
None yet
Development

No branches or pull requests

3 participants