Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In RestoreSnapshotJob, stream photo upload without reading into memory first #26

Open
todo bot opened this issue Jun 19, 2020 · 0 comments
Open
Labels
enhancement New feature or request ruby Pull requests that update Ruby code todo 🗒️

Comments

@todo
Copy link

todo bot commented Jun 19, 2020

# @todo patch this so the photo doesn't have to be read into memory
photo.image.attach(io: StringIO.new(io.read), filename: photo_filename)
photo.update_columns(updated_at: orig_updated_at)
end
# @todo This needs to handle attachments too


This issue was generated by todo based on a todo comment in bffd4d3. It's been assigned to @mrysav because they committed the code.
@todo todo bot added the todo 🗒️ label Jun 19, 2020
@todo todo bot assigned mrysav Jun 19, 2020
@mrysav mrysav changed the title patch this so the photo doesn't have to be read into memory In RestoreSnapshotJob, stream photo upload without reading into memory first Sep 20, 2020
@mrysav mrysav added the enhancement New feature or request label Sep 20, 2020
@mrysav mrysav removed their assignment Sep 21, 2020
@mrysav mrysav added the ruby Pull requests that update Ruby code label Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ruby Pull requests that update Ruby code todo 🗒️
Projects
None yet
Development

No branches or pull requests

1 participant