Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for adoptive parents #34

Open
mrysav opened this issue Sep 21, 2020 · 2 comments
Open

Add support for adoptive parents #34

mrysav opened this issue Sep 21, 2020 · 2 comments
Labels
design-required Before working on this issue, please discuss your approach with the maintainers enhancement New feature or request large-sized! ruby Pull requests that update Ruby code

Comments

@mrysav
Copy link
Owner

mrysav commented Sep 21, 2020

There is no good way to model adoptive parents.

I'm not sure what that would look like given the existing model structure. Discuss and document here if you would like to help.

@mrysav mrysav added design-required Before working on this issue, please discuss your approach with the maintainers enhancement New feature or request hacktoberfest ruby Pull requests that update Ruby code labels Sep 21, 2020
@hartly97
Copy link

I agree! Maybe just adding a link parameter?

@mrysav
Copy link
Owner Author

mrysav commented Sep 23, 2020

@hartly97 What do you mean by a link parameter?

Currently, there is a "fact" model that you can attach to a Person model, and you can also tag other Person models in a Fact model. I think a reasonable approach here would be attaching a Fact called "adoption" to the adoptee, and inside the fact, tagging the adoptive parents.

If that's the case, I think the bulk of this task would be to create some indication in the UI that shows this relationship. The biggest drawback to doing this is that I suspect the performance would not be very good, although that could be mitigated by adding another field or two to the Person model that caches this relationship.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design-required Before working on this issue, please discuss your approach with the maintainers enhancement New feature or request large-sized! ruby Pull requests that update Ruby code
Projects
None yet
Development

No branches or pull requests

2 participants