IMAP Trigger Node Binary File Attachments Corrupted

[darrengoldner]

Bug Description

Beginning around approximately commit 9f87cc2, all binary files retrieved from the IMAP trigger nodes in my workflow are overstated by approximately 2X.

To Reproduce

Create a new IMAP trigger node with credentials to any IMAP mailbox with file attachments.
Test trigger with filter criteria that include a message with attachments.
Compare binary data for attachment(s) vs expectactions

Expected behavior

Binary file attachments should be retrieved exactly as they are represented in the IMAP mailbox.

Operating System

Ubuntu 22.04.3 LTS

n8n Version

1.38.2

Node.js Version

18.18.0

Database

PostgreSQL

Execution mode

main (default)

[Joffcom]

Hey @darrengoldner,

Are the files actually bigger and corrupted or do we just show a larger size in the UI?

[darrengoldner]

Bigger and corrupted

[Joffcom]

@darrengoldner I have managed to reproduce and have created NODE-1344 as the internal ticket to fix this.

[darrengoldner]

would it be possible to merge this fix into the Latest release? It was in 1.41.1 and then we moved up to 1.42.1 on latest track. Or is there a timeline for one of the latter minor versions which have the patch to become the latest?

[netroy]

this fix should already be in the latest release. are you still seeing this issue ?

[darrengoldner]

Yes. AFAICT the behavior returned in 1.42.1. It had been resolved in 1.41.1