Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Can not use Connector behind Proxy due to upstream bug #21

Closed
HoffmannP opened this issue Mar 28, 2024 · 6 comments · Fixed by nmshd/connector#150
Closed

[BUG] Can not use Connector behind Proxy due to upstream bug #21

HoffmannP opened this issue Mar 28, 2024 · 6 comments · Fixed by nmshd/connector#150
Labels
bug Something isn't working

Comments

@HoffmannP
Copy link

Describe the bug
The connector can not be used behind a proxy due to problems with axios library (see axios/axios#925)

To Reproduce
Steps to reproduce the behavior:

  1. Start connector behind proxy with https_proxy env variable set
  2. Axios does not create a CONNECTION as required for proxying TLS but starts a simple request to the proxy

Expected behavior
connector working

@HoffmannP HoffmannP added the bug Something isn't working label Mar 28, 2024
@HoffmannP
Copy link
Author

HoffmannP commented Mar 28, 2024

A new version of the issue has been opened: axios/axios#6330
Also see the following for a short reproduction of the issue: https://codesandbox.io/p/devbox/admiring-panini-rp2pyr
It would be possible to use axios and overcome the problem: https://codesandbox.io/p/devbox/lively-meadow-j3834n

@jkoenig134
Copy link
Member

Hi Peter! Thanks for this detailed bug report.

I created a PR that should fix your issue. Would you be willing to verify that this works for you? For testing purposes I created an image for you: jkoenig134/connector-with-http-proxy:latest.

@HoffmannP
Copy link
Author

I assume ghcr.io/jkoenig134/connector-with-http-proxy:latest? Docker responds with manifest unknown

@jkoenig134
Copy link
Member

no, it's hosted on docker hub. So without ghcr.io/!

@HoffmannP
Copy link
Author

The image works and connects without any problems.

@jkoenig134
Copy link
Member

@HoffmannP Connector version 3.9.4 is now available with the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants