Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link In/LinkOut Undo Not Working Correctly #4704

Closed
My-Random-Thoughts opened this issue May 16, 2024 · 1 comment · Fixed by #4710
Closed

Link In/LinkOut Undo Not Working Correctly #4704

My-Random-Thoughts opened this issue May 16, 2024 · 1 comment · Fixed by #4710

Comments

@My-Random-Thoughts
Copy link

Current Behavior

When performing an undo after changing link in/link out connections, the connections are not set correctly.

Expected Behavior

Undo should work correctly

Steps To Reproduce

  • Two or more Link Out nodes (labelled "Out1", "Out2", ...)

  • Only one Link In node (labelled "In")

  • Connect "Out1" to "In" and see that a dotted line connects them

  • Select each node in turn ensuring that all nodes show the correct connections

  • Open properties of "In"

  • Untick "Out1" and tick "Out2"

  • Select each node in turn ensuring that all nodes show the correct connections

  • Press CTRL+Z once to undo the above change

  • Select each node in turn show the wrong connections are shown

  • Open properties of "In"

  • Ticks are shown for both "Out1" and "Out2"

  • Selecting "Out1" also shows no connection

Example flow

[{"id":"3f13efa6cd3adaee","type":"link out","z":"ecce9a260798dab7","name":"1","mode":"link","links":[],"x":315,"y":320,"wires":[]},{"id":"a6e8b21a3e0d56d4","type":"link out","z":"ecce9a260798dab7","name":"2","mode":"link","links":[],"x":315,"y":360,"wires":[]},{"id":"2fd90e621d364265","type":"link in","z":"ecce9a260798dab7","name":"Output","links":[],"x":415,"y":340,"wires":[[]]}]

Environment

  • Node-RED version: Docker - 3.1.9 (also affects 4.0.0-beta-3)
  • Node.js version: v18.20.2
  • npm version: 10.5.0
  • Platform/OS: Linux 6.1.0-18-amd64 x86_64
  • Browser: Firefox 123
@knolleary
Copy link
Member

Thanks for such a clear set of steps to reproduce this issue - that always makes our life easier.

Will investigate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants