Cannot git commit due to prettier errors

[StephenYu2018]

Operating System

Linux

RAM size

16 GB

Which step are you stuck on?

1. Fetch and merge from upstream. This should cause a merge conflict.
2. Resolve the conflicts. Add the changes to stage and run git commit.
3. Git commit should fail when running prettier.

Error Log

Running prettier ...
✔ Preparing lint-staged...
⚠ Running tasks for staged files...
  ❯ package.json — 600 files (chunk 1/5)...
    ❯ **/* — 600 files
      ✖ prettier --write --ignore-unknown [ENOENT]
  ❯ package.json — 600 files (chunk 2/5)...
    ❯ **/* — 600 files
      ✖ prettier --write --ignore-unknown [ENOENT]
  ❯ package.json — 600 files (chunk 3/5)...
    ❯ **/* — 600 files
      ✖ prettier --write --ignore-unknown [ENOENT]
  ❯ package.json — 600 files (chunk 4/5)...
    ❯ **/* — 600 files
      ✖ prettier --write --ignore-unknown [ENOENT]
  ❯ package.json — 599 files (chunk 5/5)...
    ❯ **/* — 599 files
      ✖ prettier --write --ignore-unknown [ENOENT]
↓ Skipped because of errors from tasks.
✔ Reverting to original state because of errors...
✔ Cleaning up temporary files...

✖ prettier --write --ignore-unknown failed without output (ENOENT).

✖ prettier --write --ignore-unknown failed without output (ENOENT).

✖ prettier --write --ignore-unknown failed without output (ENOENT).

✖ prettier --write --ignore-unknown failed without output (ENOENT).

✖ prettier --write --ignore-unknown failed without output (ENOENT).
Traceback (most recent call last):
  File ".git/hooks/pre-commit", line 254, in <module>
    main()
  File ".git/hooks/pre-commit", line 246, in main
    run_prettier()
  File ".git/hooks/pre-commit", line 212, in run_prettier
    subprocess.run('npx lint-staged', shell=True, check=True)
  File "/home/enyu/.pyenv/versions/3.8.15/lib/python3.8/subprocess.py", line 516, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command 'npx lint-staged' returned non-zero exit status 1.

Approaches already used to resolve the issue

I tried to run ../oppia_tools/yarn-1.22.15/bin/yarn install from ~/open-source/oppia/, but I got the following error:

[2/4] Fetching packages...
info fsevents@2.3.3: The platform "linux" is incompatible with this module.
info "fsevents@2.3.3" is an optional dependency and failed compatibility check. Excluding it from installation.
info fsevents@1.2.13: The platform "linux" is incompatible with this module.
info "fsevents@1.2.13" is an optional dependency and failed compatibility check. Excluding it from installation.
error lighthouse@9.3.0: The engine "node" is incompatible with this module. Expected version ">=14.15". Got "12.22.9"
error Found incompatible module.
info Visit https://yarnpkg.com/en/docs/cli/upgrade for documentation about this command.

Additional information

No response

[StephenYu2018]

@nikitaevg PTAL.

[AFZL210]

@StephenYu2018 can you run node -v and check which nodejs version you have? If it's something like 12.x.x then try upgrading it to 18 or 20.

[StephenYu2018]

I updated node and then ran ../oppia_tools/yarn-1.22.15/bin/yarn upgrade. Finally, running git commit worked. Thanks!

[Ash-2k3]

I am also facing the same error, I tried running the npx lint-staged to know what exactly is going wrong and here's the output:

✔ Preparing lint-staged...
⚠ Running tasks for staged files...
❯ package.json — 2 files
❯ */ — 2 files
✖ prettier --write --ignore-unknown [ENOENT]
↓ Skipped because of errors from tasks.
✔ Reverting to original state because of errors...
✔ Cleaning up temporary files...

✖ prettier --write --ignore-unknown failed without output (ENOENT).

[nikitaevg]

Have you tried running ../oppia_tools/yarn-1.22.15/bin/yarn install? Note, you might have a different version of yarn, check what directory you have in ../oppia_tools/yarn*.

[Ash-2k3]

Thanks @nikitaevg, it's working fine now. Upgraded the node first ../oppia_tools/node-16.13.0/bin/npm upgrade and then yarn ../oppia_tools/yarn-1.22.15/bin/yarn upgrade and then runnig git commit worked.

[masterboy376]

@nikitaevg, upon running ../oppia_tools/node-16.13.0/bin/npm upgrade command I am getting following error: /usr/bin/env: ‘node’: No such file or directory.
Also when running ../oppia_tools/yarn-1.22.15/bin/yarn upgrade command I am getting this error Yarn requires Node.js 4.0 or higher to be installed.
node version: 16.13.0
yarn version: 1.22.15

[nikitaevg]

This problem is not related to prettier. Have you tried looking for a solution in Google? It looks pretty common.

[masterboy376]

Trying to find solution on google

[masterboy376]

fixed the issue by manually removing old node version and installing the new one.

[Helper2020]

I am getting the same error. When I check node -v I get "Command 'node' not found"
My question should I run "../oppia_tools/yarn-/bin/yarn upgrade"?

Also, for some reason I do not have npm installed either.
Will running "sudo apt install npm" be okay or I need to have a particular version?

[nikitaevg]

Have you followed these instructions? I think you should have node after following them

[Helper2020]

Yes I did. The folder is there.

[masterboy376]

@Helper2020, go to oppia_tools directory and install node and npm if not already installed and then follow the above steps. This worked for me. Also install node version 18 or higher.

[Helper2020]

Sorry, I don't not how to do this. Do I need to run export PATH=$PATH:~/opensource/oppia_tools/node-16.13.0/bin
?

[masterboy376]

Okay, so I did a lot of hit and trial and at the end what worked for me was that cd in oppia_tools directory delete the older version of node and npm and then install the newer version, using node installation guide on linux. Alternatively, you can follow Oppia docker installation instead.

[Helper2020]

I still got the same error after I deleted the folder and installed version 20. Note: I didn't see node folder in oppia_tools after installation.
I used the following instructions from Node.js site

curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.39.7/install.sh | bash
nvm install 20

when I run node -v and npm -v I get 20.13.1 and 10.5-2

[Helper2020]

Ok well, I ran the script python -m scripts.start.py to install everything again and it worked fine