Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODO(bhenning) in core/templates/domain/editor/undo_redo/base-undo-redo.service.ts: Integrate Immutable.js to avoid the slice and ensure the returned object is truly an immutable copy. #20313

Closed
FaithAbiola opened this issue May 14, 2024 · 1 comment

Comments

@FaithAbiola
Copy link
Contributor

The TODO comment suggests that the current implementation of the getChangeList() method may not be returning an immutable copy of the change list, which could lead to potential issues if the returned list is modified elsewhere in the codebase.

Integrating Immutable.js or a similar library would help ensure that the returned changeList is not accidentally modified, which could lead to unexpected behavior in the application. This would improve the overall robustness and maintainability of the codebase.

@seanlip
Copy link
Member

seanlip commented May 26, 2024

Closing as duplicate of #20337.

@seanlip seanlip closed this as not planned Won't fix, can't repro, duplicate, stale May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants