Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ios] Crash during the Bookmark Update after the MarkID reloading/deleting #8189

Closed
kirylkaveryn opened this issue May 16, 2024 · 2 comments · Fixed by #8243
Closed

[ios] Crash during the Bookmark Update after the MarkID reloading/deleting #8189

kirylkaveryn opened this issue May 16, 2024 · 2 comments · Fixed by #8243
Labels
Bookmarks and Tracks Bookmarks, imported tracks, and KML, KMZ, KMB, GPX import or export Bug Something isn't working iOS iOS development UX User eXperience, an issue with usability

Comments

@kirylkaveryn
Copy link
Contributor

Description

When the categories list OR bookmark edit screen OR the Place Page are opened, but the category/bookmark ID becomes invalid (because of different reasons) the app will crash during the attempt to update/delete this item.

This issue is related to the #8164, #1694 , #7978

How to reproduce

use iPad

  1. Tap on the bookmark on the map
  2. go into the BM list
  3. delete the selected bookmark
  4. return to the map
  5. try to remove the bookmark by tapping on the star
  6. receive the crash because this ID is invalid

Simulator Screen Recording - iPad Air (5th generation) - 2024-05-16 at 11 19 15
image

Expected behavior

  1. The opened categories list, bookmarks list, edit bm screen, and the place page should react to the changes even during the all VC lifecycle not only the appearing/dismissing.
  2. If the current bookmark was deleted the screen should be dismissed. If content was updated - the screen should be redrawn.
@kirylkaveryn kirylkaveryn added Bug Something isn't working iOS iOS development Bookmarks and Tracks Bookmarks, imported tracks, and KML, KMZ, KMB, GPX import or export UX User eXperience, an issue with usability labels May 16, 2024
@rtsisyk
Copy link
Contributor

rtsisyk commented May 17, 2024

This is a confirmed issue, I saw it.

@biodranik
Copy link
Member

There is also a way to reproduce it on iPhone:

  1. Build a route.
  2. Select and bookmark any poi on the map.
  3. Press Bookmarks and Tracks dialog button on the left
  4. Delete that recent bookmark from this dialog.
  5. Return back to the route planning mode
  6. Delete selected POI bookmark

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bookmarks and Tracks Bookmarks, imported tracks, and KML, KMZ, KMB, GPX import or export Bug Something isn't working iOS iOS development UX User eXperience, an issue with usability
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants