Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Press ESC to exit comments mode #4589

Open
myfunnyandy opened this issue May 15, 2024 · 0 comments
Open

Press ESC to exit comments mode #4589

myfunnyandy opened this issue May 15, 2024 · 0 comments

Comments

@myfunnyandy
Copy link
Contributor

myfunnyandy commented May 15, 2024

Is your feature request related to a problem? Please describe.

Comments mode can be activated using the shortcut "C" and pressing the comments icon. This works both at the workspace and at the view mode.

To exit the comments mode the only way is to press the comments icon, which is not always intuitive and definitely not the easiest possible way. This results in impacting the workflow when having to switch between comments and design mode, which is a pretty common use case.

Describe the solution you'd like.

Pressing the ESC key will exit comments mode, so that the user will be able to continue the file in an easy and intuitive way.

Interaction

Precondition: Comments mode is activated.

When pressing the ESC key:

  1. If there is an open/expanded comment at the viewport or at the view mode, the comment is closed and the comments mode is still activated.
  2. If all the comment bubbles are closed, comments mode is exited to the default mode, which at the workspace is "edit" (indicated by the cursor icon at the toolbar) and at the viewport is "play" (indicated by the play icon at the header).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant