Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prematurely exit pimcore:bundle:install with success code if bundle is already installed #17030

Open
wants to merge 3 commits into
base: 11.x
Choose a base branch
from
Open

Prematurely exit pimcore:bundle:install with success code if bundle is already installed #17030

wants to merge 3 commits into from

Conversation

evanjamesjackson
Copy link
Contributor

@evanjamesjackson evanjamesjackson commented May 8, 2024 •
edited

Changes in this pull request

Resolves ##17029

Additional info

Choosing to first check if the given bundle is already installed, and if true prematurely exit with success. If it is preferred to provide an optional "ignore" flag instead, this PR can be closed in favour of that solution.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 8, 2024

Review Checklist

  • Target branch (11.2 for bug fixes, others 11.x)
  • Tests (if it's testable code, there should be a test for it - get help)
  • Docs (every functionality needs to be documented, see here)
  • Migration incl. install.sql (e.g. if the database schema changes, ...)
  • Upgrade notes (deprecations, important information, migration hints, ...)
  • Label
  • Milestone

@github-actions GitHub Actions
Copy link

github-actions bot commented May 8, 2024 •
edited

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@evanjamesjackson
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@evanjamesjackson evanjamesjackson changed the title Prematurely exiting with success code if bundle is already installed Prematurely exiting pimcore:bundle:install with success code if bundle is already installed May 8, 2024
@evanjamesjackson evanjamesjackson changed the title Prematurely exiting pimcore:bundle:install with success code if bundle is already installed Prematurely exiting pimcore:bundle:install with success code if bundle is already installed May 8, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@evanjamesjackson evanjamesjackson changed the title Prematurely exiting pimcore:bundle:install with success code if bundle is already installed Prematurely exit pimcore:bundle:install with success code if bundle is already installed May 13, 2024
@kingjia90 kingjia90 linked an issue May 14, 2024 that may be closed by this pull request
[Improvement]: pimcore:bundle:install should no-op if a bundle is already installed #17029
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdreesen jdreesen jdreesen left review comments

Assignees
No one assigned
Labels
Pimcore:ToDo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Improvement]: pimcore:bundle:install should no-op if a bundle is already installed
3 participants
@evanjamesjackson @jdreesen @wisconaut