Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dss: Failed to run "make test_others" #408

Open
LimingFang opened this issue Feb 15, 2022 · 0 comments
Open

dss: Failed to run "make test_others" #408

LimingFang opened this issue Feb 15, 2022 · 0 comments
Labels
type/bug Something isn't working

Comments

@LimingFang
Copy link

LimingFang commented Feb 15, 2022

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. What did you do?

  • clone this repo
  • run make test_others

rust version: 1.60.0 (stable and nightly all tried).
OS: OSX-12.2.1

2. What did you expect to see?

compile and all tests in make test_others passed.

3. What did you see instead?

Error is as following:

Checking labrpc v0.1.0 (/Users/fangliming/Documents/GitHub/workingset/talent-plan/courses/dss/labrpc)
error: this expression borrows a reference (&str) that is immediately dereferenced by the compiler
--> labrpc/src/network.rs:353:31
|
353 | if net.is_server_dead(&client_name, &server_name, server_id) {
| ^^^^^^^^^^^^ help: change this to: client_name
|
= note: -D clippy::needless-borrow implied by -D clippy::all
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
error: this expression borrows a reference (&str) that is immediately dereferenced by the compiler
--> labrpc/src/network.rs:353:45
|
353 | if net.is_server_dead(&client_name, &server_name, server_id) {
| ^^^^^^^^^^^^ help: change this to: server_name
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
error: could not compile labrpc due to 2 previous errors
warning: build failed, waiting for other jobs to finish...
error: build failed
make: *** [check] Error 101

After correct these two error, there is still one other error. But after revising these three error, everything is ok.

@LimingFang LimingFang added the type/bug Something isn't working label Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant