Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create end-to-end test to verify Prometheus operator metrics #6528

Open
simonpasquier opened this issue Apr 18, 2024 · 1 comment
Open

Create end-to-end test to verify Prometheus operator metrics #6528

simonpasquier opened this issue Apr 18, 2024 · 1 comment

Comments

@simonpasquier
Copy link
Contributor

This is a follow-up of #6513 and #6525.

To avoid future regression on key operator metrics disappearing when we update dependencies, we need to add an end-to-end test.

Key metrics involve at least the ones used in the alerts mixin the but others can be included.

Originally posted by @simonpasquier in #6525 (comment)

@afzal442
Copy link

Hey @simonpasquier this should go into metrics_test.go new file to add an end-to-end test . Can we take an example of it https://github.com/kubernetes-sigs/controller-runtime/blob/67b27f27e514bd9ac4cf9a2d84dec089ece95bf7/pkg/metrics/client_go_adapter.go#L30-L55 to create test cases for prom-op metrics?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants