Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dynamo][TVM] Fix tvm backend interface #126529

Closed
wants to merge 2 commits into from
Closed

[Dynamo][TVM] Fix tvm backend interface #126529

wants to merge 2 commits into from

Conversation

mshr-h
Copy link
Contributor

@mshr-h mshr-h commented May 17, 2024 •
edited by pytorch-bot bot

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented May 17, 2024 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/126529

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 23aec1f with merge base b36e018 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented May 17, 2024 •
edited

CLA Signed

The committers listed above are authorized under a signed CLA.

@mshr-h mshr-h marked this pull request as ready for review May 20, 2024 01:30
@mshr-h mshr-h changed the title [Dynamo][TVM] Adopt tvm backend interface to #99645 [Dynamo][TVM] Fix tvm backend interface May 20, 2024
xmfan
xmfan approved these changes May 20, 2024
View reviewed changes
Copy link
Member

@xmfan xmfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing, it would be even better if you could add a test in test/dynamo/test_backends.py to cover the scheduler/trials options

@mshr-h
Copy link
Contributor Author

mshr-h commented May 21, 2024

@xmfan
Thank you for your comment! I only added a simple test case for options since the auto_scheduler/meta_schedule stuff seems to be broken.
I'll try to fix that after this PR merged.

@xmfan
Copy link
Member

xmfan commented May 21, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label May 21, 2024
@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@xmfan
Copy link
Member

xmfan commented May 21, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@mshr-h mshr-h deleted the dynamo-tvm-args-issue branch May 22, 2024 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmfan xmfan xmfan approved these changes

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged module: dynamo open source release notes: dynamo topic: bug fixes topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Dynamo] TypeError: tvm() got an unexpected keyword argument 'options'
4 participants
@mshr-h @xmfan @pytorchmergebot @pytorchbot