Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Register AuthPage using wrong i18n key #5816

Open
BlackBearFTW opened this issue Apr 3, 2024 · 4 comments · May be fixed by #5914
Open

[BUG] Register AuthPage using wrong i18n key #5816

BlackBearFTW opened this issue Apr 3, 2024 · 4 comments · May be fixed by #5914
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@BlackBearFTW
Copy link

Describe the bug

When using the register authpage in combination with i18n, the default auth page is using the wrong key for the "Already have an account" text. It uses pages.login.buttons.haveAccount even tho in the i18n translation file offered by the refine documentation has that key in the pages.register.buttons.haveAccount. This should be changed so it matches pages.login.buttons.noAccount

Steps To Reproduce

  1. Create a refine project (for example vite)
  2. Setup i18n using the refine documentation
  3. Switch languages to a non-english language
  4. See the register page

Expected behavior

It should use the correct key and translate the value

Packages

@refinedev/core
@refinedev/antd

Additional Context

No response

@BlackBearFTW BlackBearFTW added the bug Something isn't working label Apr 3, 2024
@BatuhanW
Copy link
Member

BatuhanW commented Apr 4, 2024

Hey @BlackBearFTW thanks for the issue. We are open to contributions for this one.

@Ac-Srikanth
Copy link
Contributor

Hey @BatuhanW since the PR linking to this issue is closed. Can i take this up ?. will keep the PR template and provide the necessary info this time.

@BlackBearFTW
Copy link
Author

I do not know how to make this changelist without cloning the entire repository to local, so if someone else wants to pick this up go ahead.

@keremilhan
Copy link

I want to work on this issue. Can you assign this to me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants