Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for falsey strings #16

Closed
wants to merge 3 commits into from
Closed

Check for falsey strings #16

wants to merge 3 commits into from

Conversation

rybon
Copy link
Contributor

@rybon rybon commented Apr 23, 2019

Fixes #10.

@rybon rybon changed the title Check for 'undefined' and 'null' strings Check for falsey strings Apr 23, 2019
@rybon
Copy link
Contributor Author

rybon commented May 9, 2019

@rstacruz please review.

@rstacruz
Copy link
Owner

Thanks for this! Sorry I'm not really understanding the context of the fix, so I think I'll hold off on this change in the mean time. Feel free to reopen with more context and maybe a test suite!

@rstacruz rstacruz closed this Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Empty attributes get passed as string 'undefined' to props
2 participants
@rybon @rstacruz