Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REQUEST] Improve strict schema validation #666

Open
romanblanco opened this issue Jul 20, 2023 · 4 comments · Fixed by #659 · May be fixed by #721
Open

[REQUEST] Improve strict schema validation #666

romanblanco opened this issue Jul 20, 2023 · 4 comments · Fixed by #659 · May be fixed by #721
Labels
enhancement
Milestone
Gem 2.X.0

Comments

@romanblanco
Copy link
Member

romanblanco commented Jul 20, 2023 •
edited

Is your feature request related to a problem? Please describe.

#604 (comment)

Describe the solution you'd like

Use allPropertiesRequired and noAdditionalProperties options for json-schema gem implemented in voxpupuli/json-schema#494.

Relates to which version of OAS (OpenAPI Specification)

  • OAS3
  • OAS3.1
@romanblanco romanblanco mentioned this issue Oct 27, 2023
Closed
7 tasks
@romanblanco romanblanco linked a pull request Nov 12, 2023 that will close this issue
Upgrade json-schema #675
Closed
7 tasks
@romanblanco
Copy link
Member Author

#659 addresses same issue as #675

@romanblanco romanblanco added this to the Gem 2.X.0 milestone Nov 12, 2023
@romanblanco romanblanco linked a pull request Nov 13, 2023 that will close this issue
Update rswag-specs dependency on json-schema #659
Merged
@a-lavis
Copy link
Contributor

a-lavis commented Nov 14, 2023

@romanblanco is this issue resolved? As I understand it, we now have access to allPropertiesRequired and noAdditionalProperties from rswag-specs, but we aren't actually using them, right?

I have a draft branch up here with what I think the changes would have to look like for this issue to be resolved:
master...a-lavis:rswag:allow_any_json_schema_params

@romanblanco
Copy link
Member Author

@a-lavis you're right. It's just unblocked, not closed. Thanks!

@romanblanco romanblanco reopened this Nov 14, 2023
@a-lavis a-lavis mentioned this issue Nov 27, 2023
Open
3 tasks
@IlkhamGaysin IlkhamGaysin linked a pull request Dec 30, 2023 that will close this issue
Open
7 tasks
@IlkhamGaysin
Copy link
Contributor

IlkhamGaysin commented Dec 30, 2023 •
edited

@romanblanco
@a-lavis
hi guys, I've added two more options to keep the restrictions up to date, please take a look.
Thanks
#721

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
Gem 2.X.0
3 participants
@romanblanco @a-lavis @IlkhamGaysin