Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eugenics Archive - Remaining issues after Flash Remoting support #16356

Open
danielhjacobs opened this issue May 17, 2024 · 1 comment
Open
Labels
amf Issues relating to AMF serialization/deserialization avm1 AVM1 (ActionScript 1.0 and 2.0) issues bug Something isn't working network

Comments

@danielhjacobs
Copy link
Contributor

danielhjacobs commented May 17, 2024

Describe the bug

The images do not appear.

  • Click the magnifying glass for Search
  • Click Accept
  • Click Topics
  • Click "Agricultural Genetics"

Screenshot from 2024-05-17 09-25-50

Additionally, when searching, no search results numbers show even when there are results:

  • Click the magnifying glass for Search
  • Click Accept
  • Click the TextField for Search
  • Type "id735" (without the quotes)
  • Click the word "Search"

Screenshot from 2024-05-17 09-30-21

  • After the previous steps, click the label "Race Mixing and Marriage Laws ()" or "Hereditary Disorders ()"

Screenshot from 2024-05-17 09-35-11

A direct link to a search result does not load (for example, http://www.eugenicsarchive.org/html/eugenics/index2.html?tag=735):

Screenshot from 2024-05-17 10-16-23

Expected behavior

Clickable images should load under the list of image results:

Screenshot from 2024-05-17 09-27-10

The search for "id735" should say "Your search for "id735" returned 1 results." instead of "Your search for "id735" returned results.", the number "1" should appear in the parentheses next to both "Race Mixing and Marriage Laws" and "Hereditary Disorders":

Screenshot from 2024-05-17 09-36-44

Clicking either result after the search should load the image:

Screenshot from 2024-05-17 09-37-08

A direct link to a search result should load (for example, http://www.eugenicsarchive.org/html/eugenics/index2.html?tag=735):

Screenshot from 2024-05-17 10-18-44

Content Location

http://www.eugenicsarchive.org/eugenics/list2.pl

Affected platform

Self-hosted version

Operating system

Fedora Linux 39

Browser

Mozilla Firefox 126

Additional information

No response

@danielhjacobs danielhjacobs added bug Something isn't working network avm1 AVM1 (ActionScript 1.0 and 2.0) issues labels May 17, 2024
@danielhjacobs
Copy link
Contributor Author

Copied the requests on http://www.eugenicsarchive.org/eugenics/list2.pl to http://www.eugenicsarchive.org/amfbrowser as cURL in both Firefox with Ruffle and Pale Moon with Flash after choosing Agricultural Genetics:

Raw data in Flash:
\x00\x00\x00\x01\x00\x10amf_server_debug\x01\x00\x00\x00p\x10\x00\x0eNetDebugConfig\x00\ncoldfusion\x01\x01\x00\namfheaders\x01\x00\x00\x03amf\x01\x00\x00\x0bhttpheaders\x01\x00\x00\x09recordset\x01\x01\x00\x05error\x01\x01\x00\x05trace\x01\x01\x00\x07m_debug\x01\x01\x00\x00\x09\x00\x01\x00\x13AMFApp.getResultSet\x00\x02/4\x00\x00\x00M\n\x00\x00\x00\x01\x03\x00\x03uri\x02\x00\x19amfbrowser/flash/theme/28\x00\x0bsub_to_call\x02\x00\x13getResultSet_Result\x00\x00\x09

Raw data in Ruffle:
\x00\x00\x00\x01\x00\x10amf_server_debug\x01\x00\x00\x00`\x03\x00\ncoldfusion\x01\x01\x00\namfheaders\x01\x00\x00\x03amf\x01\x00\x00\x0bhttpheaders\x01\x00\x00\x09recordset\x01\x01\x00\x05error\x01\x01\x00\x05trace\x01\x01\x00\x07m_debug\x01\x01\x00\x00\x09\x00\x01\x00\x13AMFApp.getResultSet\x00\x02/1\x00\x00\x00M\n\x00\x00\x00\x01\x03\x00\x03uri\x02\x00\x19amfbrowser/flash/theme/28\x00\x0bsub_to_call\x02\x00\x13getResultSet_Result\x00\x00\x09

Response with Ruffle (attached message):
ruffle_message.txt
Response with Flash (attached message):
flash_message.txt
The encoding of the data may be the issue, meaning this may be an AMF0 issue or an issue of a misuse of AMF0 by NetConnection. However, unlike #16381, the response is nearly identical, with a minor two character difference between the Flash and Ruffle responses. But this difference may be enough to change the output.

@danielhjacobs danielhjacobs added the amf Issues relating to AMF serialization/deserialization label May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
amf Issues relating to AMF serialization/deserialization avm1 AVM1 (ActionScript 1.0 and 2.0) issues bug Something isn't working network
Projects
None yet
Development

No branches or pull requests

1 participant