Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Claiming "no dependencies" is false #1191

Open
mrjones2014 opened this issue Oct 22, 2021 · 2 comments
Open

Claiming "no dependencies" is false #1191

mrjones2014 opened this issue Oct 22, 2021 · 2 comments

Comments

@mrjones2014
Copy link

Description

The README.md claims "no dependencies" but that is false.

Steps to reproduce

Look at the package.json

Expected result

There should be no dependencies.

Actual result

There are dependencies.

Additional context

Even if you ignore the things that really should be in devDependencies (npm, i, and @types/picturefill), video.js is still a real dependency.

@sachinchoolur
Copy link
Owner

These are optional dependencies. lightGallery will work without these dependencies. For example, videoJs is required only if you want to use videojs with lightGallery.
I think this can be moved to optionaldependencies field

@stof
Copy link

stof commented Mar 7, 2022

As video.js is meant to be provided by the project rather than being required by lightgallery, I think peerDependencies would even be better (with peerDependenciesMeta marking it optional).

And npm and i should probably be removed entirely (I suspect it was a result of calling npm i npm i something --save by mistake)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants