Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Segement downloaded in 5 ms, wrong information #6623

Closed
Iragne opened this issue May 16, 2024 · 5 comments · Fixed by #6657
Closed

Segement downloaded in 5 ms, wrong information #6623

Iragne opened this issue May 16, 2024 · 5 comments · Fixed by #6657
Assignees
Labels
priority: P3 Useful but not urgent type: enhancement New feature or request
Milestone

Comments

@Iragne
Copy link
Contributor

Iragne commented May 16, 2024

Have you read the Tutorials?

Yes
Have you read the FAQ and checked for duplicate open issues?

Yes
If the question is related to FairPlay, have you read the tutorial?

N/A

What version of Shaka Player are you using?
Latest

What browser and OS are you using?
Firefox

Please ask your question
When i looked to how the player is behaving against bandwidth changed i found that the network engine was sending wired information to the ABR manager

Segment downloaded: contentType=video deltaTimeMs=5 numBytes=132328 lastTimeChosenMs=1715701213390 enabled=true

Segment downloaded: contentType=video deltaTimeMs=153 numBytes=71224 lastTimeChosenMs=1715701213390 enabled=true

Segment downloaded: contentType=video deltaTimeMs=604

deltaTimeMs=5 so much data in so short time is quite wired to me. is that something possible can it be linked to wrong information.
have you experience it ?

Should we put some filter to avoid to count that value inside the ABR manager
Screenshot 2024-05-14 at 17 40 20

@Iragne Iragne added the type: question A question from the community label May 16, 2024
@Iragne Iragne changed the title Segemnt downloaded in 5 ms, wrong information Segement downloaded in 5 ms, wrong information May 16, 2024
@Iragne
Copy link
Contributor Author

Iragne commented May 16, 2024

additionally we are only passing information of the bandwidth during the on-progress and never at the end of the download of the segment. I'm wondering if we should also add it when the download is ended. event if it's kind of duplicate

here the end of the request

if (connectionTimer) {

here the way it's calculated in the on progress

@joeyparrish
Copy link
Member

deltaTimeMs=5 so much data in so short time is quite wired to me. is that something possible can it be linked to wrong information.

Browser caching could explain bad data being fed to ABR manager. Can you try again with caching disabled/cleared in your browser?

@avelad avelad added the status: waiting on response Waiting on a response from the reporter(s) of the issue label May 17, 2024
@Iragne
Copy link
Contributor Author

Iragne commented May 17, 2024

@joeyparrish sorry i should mention this but the test had been done with cache disable on FF

@shaka-bot shaka-bot removed the status: waiting on response Waiting on a response from the reporter(s) of the issue label May 17, 2024
@avelad
Copy link
Collaborator

avelad commented May 22, 2024

We should use something like https://github.com/Dash-Industry-Forum/dash.js/blob/development/src/streaming/models/ThroughputModel.js#L250

Since I want to make improvements to the ABR, I assign it to myself and move to improvement.

@avelad avelad self-assigned this May 22, 2024
@avelad avelad added type: enhancement New feature or request priority: P3 Useful but not urgent and removed type: question A question from the community labels May 22, 2024
@avelad avelad added this to the v4.9 milestone May 22, 2024
avelad added a commit that referenced this issue May 23, 2024
@Iragne
Copy link
Contributor Author

Iragne commented May 24, 2024

@avelad that is lovely i was pushing the same PR you were too fast !!!! thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: P3 Useful but not urgent type: enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants