-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dragging the seek bar seeks and pans the view in VR mode, instead of just seeking #6625
Comments
@absidue Can you share a video of the issue? Thanks! |
I haven't figured out a way to record the window that also records the cursor. The fix is probably relatively simple, just a few |
PRs are welcome if you want to try that, @absidue |
I would definitely prefer to open pull requests, than being limited to having to open bug reports, but as we've discussed on other issues the CLA requirement, which you've mentioned is a Google policy so you can't do anything about it, prevents me from doing so. |
Built and tested the demo locally and your pull request fixes the issue. Thank you! |
Have you read the FAQ and checked for duplicate open issues?
Yes
If the problem is related to FairPlay, have you read the tutorial?
not applicable
What version of Shaka Player are you using?
4.8.4 and nightly demo
Can you reproduce the issue with our latest release version?
Yes
Can you reproduce the issue with the latest code from
main
?Yes (nightly demo)
Are you using the demo app or your own custom app?
Demo
If custom app, can you reproduce the issue using our demo app?
Yes
What browser and OS are you using?
Firefox 126.0, Windows 10
For embedded devices (smart TVs, etc.), what model and firmware version are you using?
Not applicable
What are the manifest and license server URIs?
https://shaka-player-demo.appspot.com/demo/#audiolang=en-US;textlang=en-US;uilang=en-US;asset=https://demo.theoplayer.com/hubfs/videos/natgeo/playlist.m3u8;panel=ALL_CONTENT;panelData=VR;build=uncompiled
What configuration are you using? What is the output of
player.getConfiguration()
?Default
What did you do?
What did you expect to happen?
The events to only get picked up by the controls themselves.
What actually happened?
Dragging the sliders also panned the view and scrolling through the player menu changed the FOV.
Are you planning send a PR to fix it?
No (because of the requirement to sign the CLA).
The text was updated successfully, but these errors were encountered: