Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dragging the seek bar seeks and pans the view in VR mode, instead of just seeking #6625

Closed
absidue opened this issue May 16, 2024 · 6 comments · Fixed by #6677
Closed

Dragging the seek bar seeks and pans the view in VR mode, instead of just seeking #6625

absidue opened this issue May 16, 2024 · 6 comments · Fixed by #6677
Assignees
Labels
component: UI The issue involves the Shaka Player UI priority: P2 Smaller impact or easy workaround type: bug Something isn't working correctly
Milestone

Comments

@absidue
Copy link

absidue commented May 16, 2024

Have you read the FAQ and checked for duplicate open issues?
Yes

If the problem is related to FairPlay, have you read the tutorial?

not applicable

What version of Shaka Player are you using?

4.8.4 and nightly demo

Can you reproduce the issue with our latest release version?
Yes

Can you reproduce the issue with the latest code from main?
Yes (nightly demo)

Are you using the demo app or your own custom app?
Demo

If custom app, can you reproduce the issue using our demo app?
Yes

What browser and OS are you using?
Firefox 126.0, Windows 10

For embedded devices (smart TVs, etc.), what model and firmware version are you using?
Not applicable

What are the manifest and license server URIs?
https://shaka-player-demo.appspot.com/demo/#audiolang=en-US;textlang=en-US;uilang=en-US;asset=https://demo.theoplayer.com/hubfs/videos/natgeo/playlist.m3u8;panel=ALL_CONTENT;panelData=VR;build=uncompiled

What configuration are you using? What is the output of player.getConfiguration()?
Default

What did you do?

  1. Open a video in VR mode.
  2. Dragged the seek bar and volume sliders
  3. Scrolled through the player menu.

What did you expect to happen?
The events to only get picked up by the controls themselves.

What actually happened?
Dragging the sliders also panned the view and scrolling through the player menu changed the FOV.

Are you planning send a PR to fix it?
No (because of the requirement to sign the CLA).

@absidue absidue added the type: bug Something isn't working correctly label May 16, 2024
@shaka-bot shaka-bot added this to the v4.9 milestone May 16, 2024
@avelad avelad added component: UI The issue involves the Shaka Player UI priority: P2 Smaller impact or easy workaround labels May 17, 2024
@avelad
Copy link
Collaborator

avelad commented May 17, 2024

@absidue Can you share a video of the issue? Thanks!

@avelad avelad added the status: waiting on response Waiting on a response from the reporter(s) of the issue label May 20, 2024
@absidue
Copy link
Author

absidue commented May 24, 2024

I haven't figured out a way to record the window that also records the cursor. The fix is probably relatively simple, just a few preventDefault() and stopPropagation calls on the relevant events. I'm sorry that I wasn't able to provide a video of the issue, if it can't be solved without that, feel free to close the issue.

@shaka-bot shaka-bot removed the status: waiting on response Waiting on a response from the reporter(s) of the issue label May 24, 2024
@joeyparrish
Copy link
Member

The fix is probably relatively simple, just a few preventDefault() and stopPropagation calls on the relevant events.

PRs are welcome if you want to try that, @absidue

@absidue
Copy link
Author

absidue commented May 25, 2024

The fix is probably relatively simple, just a few preventDefault() and stopPropagation calls on the relevant events.

PRs are welcome if you want to try that, @absidue

I would definitely prefer to open pull requests, than being limited to having to open bug reports, but as we've discussed on other issues the CLA requirement, which you've mentioned is a Google policy so you can't do anything about it, prevents me from doing so.

@avelad
Copy link
Collaborator

avelad commented May 27, 2024

@absidue PR: #6677

@absidue
Copy link
Author

absidue commented May 27, 2024

Built and tested the demo locally and your pull request fixes the issue. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: UI The issue involves the Shaka Player UI priority: P2 Smaller impact or easy workaround type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants