Crash with ViewModel 2.8

[Pitel]

Description

LeakCanary is not working with ViewModel 2.8, causing crash

Steps to Reproduce

1. Have a working project with LC 2.14 and ViewModel 2.7
2. Upgrade to VM 2.8
3. Observe crash

Expected behavior: Not crashing

Version Information

• LeakCanary version: 2.14
• Android OS version: Irrelevant
• Gradle version: Irrelevant

Additional Information

java.lang.AbstractMethodError: abstract method "androidx.lifecycle.ViewModel androidx.lifecycle.ViewModelProvider$Factory.create(kotlin.reflect.KClass, androidx.lifecycle.viewmodel.CreationExtras)"
                            	at androidx.lifecycle.viewmodel.ViewModelProviderImpl.getViewModel$lifecycle_viewmodel_release(ViewModelProviderImpl.kt:69)
                            	at androidx.lifecycle.viewmodel.ViewModelProviderImpl.getViewModel$lifecycle_viewmodel_release$default(ViewModelProviderImpl.kt:47)
                            	at androidx.lifecycle.ViewModelProvider.get(ViewModelProvider.android.kt:91)
                            	at androidx.lifecycle.ViewModelProvider.get(ViewModelProvider.android.kt:109)
                            	at leakcanary.internal.ViewModelClearedWatcher$Companion.install(ViewModelClearedWatcher.kt:61)
                            	at leakcanary.internal.AndroidXFragmentDestroyWatcher.invoke(AndroidXFragmentDestroyWatcher.kt:66)
                            	at leakcanary.internal.AndroidXFragmentDestroyWatcher.invoke(AndroidXFragmentDestroyWatcher.kt:25)
                            	at leakcanary.FragmentAndViewModelWatcher$lifecycleCallbacks$1.onActivityCreated(FragmentAndViewModelWatcher.kt:59)

[pyricau]

Thanks for filing. This looks awfully similar to #2314, and I believe it's actually the same bug, caused by a revert of the fix on the Google side.

At the time, the fix was implemented in Lifecycle 2.5.0-rc02: https://android-review.googlesource.com/c/platform/frameworks/support/+/2108693/1/lifecycle/lifecycle-viewmodel/src/main/java/androidx/lifecycle/ViewModelProvider.kt#189

The key part was the addition of a try catch ("AGP has some desugaring issues associated with compileOnly dependencies")

In February, this change landed, migrating the code to KMP and seemingly not backporting the fix: https://android-review.googlesource.com/c/platform/frameworks/support/+/2966765/18/lifecycle/lifecycle-viewmodel/src/androidMain/kotlin/androidx/lifecycle/ViewModelProvider.android.kt#b179

[pyricau]

Filed https://issuetracker.google.com/issues/341792251

[msasikanth]

I am having the same issue, but the crash didn't happen for me on Android 14, but when I tried it with older versions it crashed.

[vullnetlimani]

The same issue hopefully they fix it as well I am going to comment on the issue as well ...

Was thinking first what's going on till I got it 😅 and than landed here, after searching the problem!

[pyricau]

Fixed here, not sure when that'll get released: https://android-review.googlesource.com/c/platform/frameworks/support/+/3096018

lifecycle 2.8.1 was just released today, so hopefully this goes into next release... in 2 weeks?