Add missing default configuration options

[glowcloud]

There are configuration options, such as modelPropertyMacro and parameterMacro, which do not have any default values defined in:

swagger-ui/src/core/config/defaults.js

Line 6 in d5e56e5

const defaultOptions = Object.freeze({

We need to identify all of the missing options and assign them default values.

[glowcloud]

The missing configs are:

• operationsSorter
• tagsSorter
• onComplete
• modelPropertyMacro
• parameterMacro

[char0n]

I think there is additional request.curlOptions as well. But needs to be researched first.

[glowcloud]

request.curlOptions is set inside of requestInterceptor:

This can be set on the mutated request in the requestInterceptor function. For example request.curlOptions = ["-g", "--limit-rate 20k"]

The default for it is:

 requestInterceptor: (a) => a

so perhaps it should be:

requestInterceptor: (request) => {
   request.curlOptions = null;
   return request;
}

[glowcloud]

Potential default values for each of them:

• onComplete: () => {} - defined as Function=NOOP in documentation, used here:

  swagger-ui/src/core/plugins/on-complete/index.js

  Lines 13 to 23 in d5e56e5

  	updateJsonSpec: (ori, system) => (...args) => {
  	const cb = system.getConfigs().onComplete
  	if(engaged && typeof cb === "function") {
  	// call `onComplete` on next tick, which allows React to
  	// reconcile the DOM before we notify the user
  	setTimeout(cb, 0)
  	engaged = false
  	}
  	return ori(...args)
  	}

• modelPropertyMacro: null - so that we don't run visitors / plugins for these
• parameterMacro: null
• requestInterceptor / request.curlOptions:

  (request) => {
     request.curlOptions = [];
     return request;
  }

• operationsSorter: null
• tagsSorter: null

operationsSorter and tagsSorter are used here:

swagger-ui/src/core/plugins/spec/selectors.js

Lines 263 to 279 in d5e56e5

	export const taggedOperations = (state) => ({ getConfigs }) => {
	let { tagsSorter, operationsSorter } = getConfigs()
	return operationsWithTags(state)
	.sortBy(
	(val, key) => key, // get the name of the tag to be passed to the sorter
	(tagA, tagB) => {
	let sortFn = (typeof tagsSorter === "function" ? tagsSorter : sorters.tagsSorter[ tagsSorter ])
	return (!sortFn ? null : sortFn(tagA, tagB))
	}
	)
	.map((ops, tag) => {
	let sortFn = (typeof operationsSorter === "function" ? operationsSorter : sorters.operationsSorter[ operationsSorter ])
	let operations = (!sortFn ? ops : ops.sort(sortFn))
	return Map({ tagDetails: tagDetails(state, tag), operations: operations })
	})
	}

Considering that they are supposed to be sorting functions, I think we should have them as null so that they don't run at all. In our configuration, it says that they are: Function=(a => a) and making that default wouldn't sort anything as well, so it's also an option.

[char0n]

Yes, good choice for the defaults. I would also go for a nullable-function (typecaster) for the onComplete for consistency. There is a check in code present to assert if it's a function.

For the curlOptions, as established in the PR already, we want to go for:

requestInterceptor: (request) => {
   request.curlOptions = [];
   return request;
}

[char0n]

Addressed in #9949