Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ThanosSidecarBucketOperationsFailed alert is flaky #7369

Open
cannonpalms opened this issue May 17, 2024 · 0 comments
Open

ThanosSidecarBucketOperationsFailed alert is flaky #7369

cannonpalms opened this issue May 17, 2024 · 0 comments

Comments

@cannonpalms
Copy link

cannonpalms commented May 17, 2024

Alert defined here:

{
alert: 'ThanosSidecarBucketOperationsFailed',
annotations: {
description: 'Thanos Sidecar {{$labels.instance}}%s bucket operations are failing' % location,
summary: 'Thanos Sidecar bucket operations are failing',
},
expr: |||
sum by (%(dimensions)s) (rate(thanos_objstore_bucket_operation_failures_total{%(selector)s}[5m])) > 0
||| % thanos.sidecar,
'for': '5m',
labels: {
severity: 'critical',
},

Failures happen in distributed systems. Shouldn't we be alerting on the percentage of failed bucket operations rather than the simple rate of failures?

I'd propose rewriting the alert to something like this:

sum by (%(dimensions)s) (rate(thanos_objstore_bucket_operation_failures_total{%(selector)s}[5m]))
/ 
sum by (%(dimensions)s) (rate(thanos_objstore_bucket_operations_total{%(selector)s}[5m]))
> THRESHOLD

What should this THRESHOLD be? Should we make this change to the alert?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant