Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prettier should be enforced in circleci #10866

Open
18 tasks
RohanTalip opened this issue May 1, 2024 · 0 comments
Open
18 tasks

prettier should be enforced in circleci #10866

RohanTalip opened this issue May 1, 2024 · 0 comments

Comments

@RohanTalip
Copy link
Contributor

RohanTalip commented May 1, 2024

Issue description

prettier should be enforced in circleci

Expected Behavior

prettier formatting should be enforced in circleci, perhaps via prettier --check or some other mechanism.

Actual Behavior

prettier formatting is not currently enforced in circleci.

There are already some files that are in the master branch that are changed when prettier is run on them.

Steps to reproduce

  • Check out the master branch
  • Run npm run format

My Environment

Dependency Version
Operating System macOS
Node.js version x.y.zzz
Typescript version x.y.zzz
TypeORM version x.y.zzz

Additional Context

No response

Relevant Database Driver(s)

  • aurora-mysql
  • aurora-postgres
  • better-sqlite3
  • cockroachdb
  • cordova
  • expo
  • mongodb
  • mysql
  • nativescript
  • oracle
  • postgres
  • react-native
  • sap
  • spanner
  • sqlite
  • sqlite-abstract
  • sqljs
  • sqlserver

Are you willing to resolve this issue by submitting a Pull Request?

Yes, I have the time, but I don't know how to start. I would need guidance (more on the circleci side).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant