Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instead of experimental decorators use the full version of decorators introduced in TS 5.0 #10869

Open
18 tasks
venkateshwarant opened this issue May 2, 2024 · 1 comment

Comments

@venkateshwarant
Copy link

venkateshwarant commented May 2, 2024

Feature Description

I'm keen in keeping up my codebase modern, well maintained and doesn't want to be left out.

Now that decorators are a real thing with Typescript 5.0. It is finally the time to actually remove these two typescript configurations.

"emitDecoratorMetadata": true,
"experimentalDecorators": true,

This tech debt in typeorm blocks me from using the full version of the decorators introduced in TS5.0

The Solution

Here are some of the examples on implementing the decorators with experimental flags disabled.
https://devblogs.microsoft.com/typescript/announcing-typescript-5-0/#decorators

Also, decorator metadata is introduced in typescript in 5.2
https://devblogs.microsoft.com/typescript/announcing-typescript-5-2/#decorator-metadata

As typeorm is already on typescript 5.3.3. I don't see any issues in migrating the decorators.

Considered Alternatives

I don't see any alternatives for this issue. If we don't keep up with the constantly evolving typescript version, I'm afraid most softwares wouldn't be able to use typeorm.

Additional Context

No response

Relevant Database Driver(s)

  • aurora-mysql
  • aurora-postgres
  • better-sqlite3
  • cockroachdb
  • cordova
  • expo
  • mongodb
  • mysql
  • nativescript
  • oracle
  • postgres
  • react-native
  • sap
  • spanner
  • sqlite
  • sqlite-abstract
  • sqljs
  • sqlserver

Are you willing to resolve this issue by submitting a Pull Request?

Yes, I have the time, and I know how to start.

@markedwards
Copy link

This seems to be a duplicate of #9862

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants