-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI/Build] Add health check #4868
base: main
Are you sure you want to change the base?
Conversation
cfb0da0
to
e7f7b01
Compare
Can you explain a bit about what |
It's explained in those links. But basically, if one uses autoheal docker image to monitor other images that have the HEALTHCHECK present, then that autoheal will restart the image if the health condition fails. Often vLLM fails, but the entire image still goes on in unhealthy state. It's built into moby, just not built into docker and is currently as separate image as explained in those links: moby/moby#23218 |
# https://docs.docker.com/reference/dockerfile/#healthcheck | ||
# https://hub.docker.com/r/willfarrell/autoheal/ | ||
HEALTHCHECK --interval=5m --timeout=10s \ | ||
CMD curl -f http://localhost/health || exit 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit but 4 spaces indent is standard for this file
CMD curl -f http://localhost/health || exit 1 | |
CMD curl -f http://localhost/health || exit 1 |
# https://docs.docker.com/reference/dockerfile/#healthcheck | ||
# https://hub.docker.com/r/willfarrell/autoheal/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please leave a written out comment before sharing these links
https://hub.docker.com/r/willfarrell/autoheal/
https://docs.docker.com/reference/dockerfile/#healthcheck
To deal with issues like this:
#4108
#4344
FIX #4867