Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

settings: Replace 'Prevent users from changing their name' with group-based policy. #30126

Closed
wants to merge 1 commit into from
Closed

settings: Replace 'Prevent users from changing their name' with group-based policy. #30126

wants to merge 1 commit into from

Conversation

Aditya8840
Copy link
Collaborator

Replaces the 'Prevent users from changing their name' setting with a flexible 'Who can change their name' option in SETTINGS / ORGANIZATION PERMISSIONS.

Uses the new groups system for implementation.
Updated documentation accordingly.

This commit fixes #30077.

Screenshots and screen captures:
image
image

Self-review checklist
  • Self-reviewed the changes for clarity and maintainability
    (variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

  • Explains differences from previous plans (e.g., issue description).
  • Highlights technical choices and bugs encountered.
  • Calls out remaining decisions and concerns.
  • Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

  • Each commit is a coherent idea.
  • Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

  • Visual appearance of the changes.
  • Responsiveness and internationalization.
  • Strings and tooltips.
  • End-to-end functionality of buttons, interactions and flows.
  • Corner cases, error conditions, and easily imagined bugs.

@zulipbot
Copy link
Member

Hello @zulip/server-settings members, this pull request was labeled with the "area: settings (admin/org)" label, so you may want to check it out!

@Aditya8840 Aditya8840 closed this May 18, 2024
@zulipbot
Copy link
Member

Hello @Aditya8840, it seems like you have referenced #30077 in your pull request description, but you have not referenced them in your commit message description(s). Referencing an issue in a commit message automatically closes the corresponding issue when the commit is merged, which makes the issue tracker easier to manage.

Please run git commit --amend in your command line client to amend your commit message description with Fixes #30077..

An example of a correctly-formatted commit:

commit fabd5e450374c8dde65ec35f02140383940fe146
Author: zulipbot
Date:   Sat Mar 18 13:42:40 2017 -0700

    pull requests: Check PR commits reference when issue is referenced.

    Fixes #51.

To learn how to write a great commit message, please refer to our guide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area: settings (admin/org) priority: high size: XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make name change permissions more flexible
2 participants
@Aditya8840 @zulipbot