Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to notify users when they are DMing a guest #30078

Open
alya opened this issue May 13, 2024 · 5 comments · May be fixed by #30222
Open

Add option to notify users when they are DMing a guest #30078

alya opened this issue May 13, 2024 · 5 comments · May be fixed by #30222
Assignees
@adnan-td
Labels
area: settings (admin/org) help wanted in progress new feature A proposed new feature for the product

Comments

@alya
Copy link
Contributor

alya commented May 13, 2024 •
edited

Some organizations want users to be very aware when they are sending a message to a guest, to minimize the risk of information being shared inappropriately. To address this, we should add an option to display a compose banner when a DM has a guest recipient.

Banner

  • Color: yellow
  • Content:
    • {user1} is a guest in this organization.
    • {user1}, {user2} and {user3} are guests in this organization.
  • Button: x

Notes:

  • The banner text needs to be tagged for translation. We can adjust the banner wording if this is awkward to tag for translation properly.

Setting

  • Where: SETTINGS / ORGANIZATION PERMISSIONS > Guests, right after "Display “(guest)” after names of guest users".
  • Label: Warn when DMing a guest

Help center

This feature should be documented in a new section on https://zulip.com/help/guest-users.

CZO thread
@alya alya added area: settings (admin/org) new feature A proposed new feature for the product labels May 13, 2024
@zulipbot
Copy link
Member

Hello @zulip/server-settings members, this issue was labeled with the "area: settings (admin/org)" label, so you may want to check it out!

@harshsbhat
Copy link
Collaborator

@zulipbot claim

@zulipbot
Copy link
Member

Hello @harshsbhat!

Thanks for your interest in Zulip! You have attempted to claim an issue without the label "help wanted". You can only claim and submit pull requests for issues with the help wanted label.

If this is your first time here, we recommend reading our guide for new contributors before getting started.

@alya alya changed the title [WIP] Add option to notify users when they are DMing a guest Add option to notify users when they are DMing a guest May 20, 2024
adnan-td added a commit to adnan-td/zulip that referenced this issue May 27, 2024
@adnan-td
realm: Add setting to notify user on DMing guest.
22eecd9 
This commit adds new realm setting to control notifying users
of guest users in DM recipients.

Fixes part of zulip#30078.
@adnan-td adnan-td linked a pull request May 27, 2024 that will close this issue
Open
12 tasks
adnan-td added a commit to adnan-td/zulip that referenced this issue May 27, 2024
@adnan-td
realm: Add setting to notify user on DMing guest.
0162b11 
This commit adds new realm setting to control notifying users
of guest users in DM recipients.

Fixes part of zulip#30078.
adnan-td added a commit to adnan-td/zulip that referenced this issue May 30, 2024
@adnan-td
realm: Add setting to notify user on DMing guest.
f0c0697 
Adds new realm setting to control notifying users
of guest users in DM recipients.

Add compose banner above composebox when private message
contains one or many guests in the recipients.

Fixes: zulip#30078.
adnan-td added a commit to adnan-td/zulip that referenced this issue May 30, 2024
@adnan-td
realm: Add setting to notify user on DMing guest.
c1f0f9b 
Adds new realm setting to control notifying users
of guest users in DM recipients.

Add compose banner above composebox when private message
contains one or many guests in the recipients.

Fixes: zulip#30078.
adnan-td added a commit to adnan-td/zulip that referenced this issue May 31, 2024
@adnan-td
realm: Add setting to notify user on DMing guest.
219bea3 
Adds new realm setting to control notifying users
of guest users in DM recipients.

Add compose banner above composebox when private message
contains one or many guests in the recipients.

Fixes: zulip#30078.
adnan-td added a commit to adnan-td/zulip that referenced this issue May 31, 2024
@adnan-td
realm: Add setting to notify user on DMing guest.
89fd721 
Adds new realm setting to control notifying users
of guest users in DM recipients.

Add compose banner above composebox when private message
contains one or many guests in the recipients.

Fixes: zulip#30078.
adnan-td added a commit to adnan-td/zulip that referenced this issue May 31, 2024
@adnan-td
realm: Add setting to notify user on DMing guest.
e418059 
Adds new realm setting to control notifying users
of guest users in DM recipients.

Add compose banner above composebox when private message
contains one or many guests in the recipients.

Fixes: zulip#30078.
adnan-td added a commit to adnan-td/zulip that referenced this issue May 31, 2024
@adnan-td
realm: Add setting to notify user on DMing guest.
94fab58 
Adds new realm setting to control notifying users
of guest users in DM recipients.

Add compose banner above composebox when private message
contains one or many guests in the recipients.

Fixes: zulip#30078.
adnan-td added a commit to adnan-td/zulip that referenced this issue Jun 1, 2024
@adnan-td
realm: Add setting to notify user on DMing guest.
3182c8d 
Adds new realm setting to control notifying users
of guest users in DM recipients.

Add compose banner above composebox when private message
contains one or many guests in the recipients.

Fixes: zulip#30078.
@adnan-td
Copy link
Collaborator

adnan-td commented Jun 1, 2024

@zulipbot claim

@zulipbot
Copy link
Member

zulipbot commented Jun 1, 2024

Hello @adnan-td!

Thanks for your interest in Zulip! You have attempted to claim an issue without the label "help wanted". You can only claim and submit pull requests for issues with the help wanted label.

If this is your first time here, we recommend reading our guide for new contributors before getting started.

@alya alya mentioned this issue Jun 4, 2024
Open
adnan-td added a commit to adnan-td/zulip that referenced this issue Jun 6, 2024
@adnan-td
realm: Add setting to notify user on DMing guest.
b00223f 
Adds new realm setting to control notifying users
of guest users in DM recipients.

Add compose banner above composebox when private message
contains one or many guests in the recipients.

Fixes: zulip#30078.
adnan-td added a commit to adnan-td/zulip that referenced this issue Jun 6, 2024
@adnan-td
realm: Add setting to notify user on DMing guest.
db84aa0 
Adds new realm setting to control notifying users
of guest users in DM recipients.

Add compose banner above composebox when private message
contains one or many guests in the recipients.

Fixes: zulip#30078.
adnan-td added a commit to adnan-td/zulip that referenced this issue Jun 8, 2024
@adnan-td
realm: Add setting to notify user on DMing guest.
f469014 
Adds new realm setting to control notifying users
of guest users in DM recipients.

Add compose banner above composebox when private message
contains one or many guests in the recipients.

Fixes: zulip#30078.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adnan-td adnan-td

Labels
area: settings (admin/org) help wanted in progress new feature A proposed new feature for the product
Projects
Zulip 9.0 priorities
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

organization_permissions: Add setting to notify user of guest recipient in DM. adnan-td/zulip
4 participants
@alya @zulipbot @adnan-td @harshsbhat