Build fails after running npx install-expo-modules@latest command because code added to wrong location in android/app/build.gradle

[jehillert]

Summary

See image below. I ran npx install-expo-modules@latest and it added code to the wrong place in android/app/build.gradle. I would guess this happened because the code for the command looks for the first set of curly braces instead of the first set of curly braces where the open brace is preceeded by "React"?

The command also added code to the podfile that was already there.

What platform(s) does this occur on?

Android
iOS

SDK Version

50.0.0

Environment

n/a

Minimal reproducible example

private repo

[byCedric]

Hi @jehillert! Thanks for the issue report. Unfortunately, I can't reproduce this issue.

The added code is handled by the updateAndroidGradleFile method, which uses appendContentsInsideDeclarationBlock from config plugins. This method does take react { into account, and should not write to the sentry { block.

Is it possible to provide a repository with a project that has the behavior you are describing?

[jehillert]

Hi @jehillert! Thanks for the issue report. Unfortunately, I can't reproduce this issue.

The added code is handled by the updateAndroidGradleFile method, which uses appendContentsInsideDeclarationBlock from config plugins. This method does take react { into account, and should not write to the sentry { block.

Is it possible to provide a repository with a project that has the behavior you are describing?

I could add you to my repo temporarily, or copy/paste the content of any configuration files you want to see here. If that would be helpful. Can't really make the repo public though.

[byCedric]

@jehillert I think it's fine to create a project from a template, and only copy-ing the native Android files before running npx install-expo-modules@latest. If that results in the behavior you are describing, that's something we can work with. It doesn't need to have the JS code, or any iOS code, just the Android native files.

[jehillert]

Ok, will try that and follow up here in a bit

[jehillert]

@byCedric You should be able to reproduce with this repo. I put steps to reproduce in the Readme file.

https://github.com/jehillert/expo-modules-int-issue-28892