Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expo-video-thumbnails crash on bad uri #27936

Closed
quick691fr opened this issue Mar 29, 2024 · 2 comments · Fixed by #28961
Closed

expo-video-thumbnails crash on bad uri #27936

quick691fr opened this issue Mar 29, 2024 · 2 comments · Fixed by #28961
Labels
help wanted Issue accepted

Comments

@quick691fr
Copy link

Minimal reproducible example

https://github.com/quick691fr/test-expo-thumbnail

What platform(s) does this occur on?

Android

Did you reproduce this issue in a development build?

Yes

Summary

On incorrect URL (not found, connection reset, ...), getThumbnailAsync() method should reject the promise with error, instead app is crashing with error :

java.lang.RuntimeException: setDataSource failed: status = 0x80000000
  android.media.MediaMetadataRetriever._setDataSource(Native Method)
  android.media.MediaMetadataRetriever.setDataSource(MediaMetadataRetriever.java:103)
  expo.modules.videothumbnails.VideoThumbnailsModule$GetThumbnail.execute(VideoThumbnailsModule.kt:85)
  expo.modules.videothumbnails.VideoThumbnailsModule$definition$lambda$4$lambda$2$$inlined$withModuleScope$1.invokeSuspend(VideoThumbnailsModule.kt:114)
  kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
  kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:106)
  kotlinx.coroutines.internal.LimitedDispatcher.run(LimitedDispatcher.kt:42)
  kotlinx.coroutines.scheduling.TaskImpl.run(Tasks.kt:95)
  kotlinx.coroutines.scheduling.CoroutineScheduler.runSafely(CoroutineScheduler.kt:570)
  kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.executeTask(CoroutineScheduler.kt:750)
  kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.runWorker(CoroutineScheduler.kt:677)
  kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(CoroutineScheduler.kt:664)

Environment

expo-env-info 1.2.0 environment info:
    System:
      OS: Windows 11 10.0.22631
    Binaries:
      Node: 20.10.0 - C:\Program Files\nodejs\node.EXE
      Yarn: 1.22.19 - C:\Program Files (x86)\Yarn\bin\yarn.CMD
      npm: 10.5.0 - C:\Program Files\nodejs\npm.CMD
    npmPackages:
      expo: ~50.0.14 => 50.0.14 
      react: 18.2.0 => 18.2.0 
      react-native: 0.73.6 => 0.73.6 
    Expo Workflow: bare

Expo Doctor Diagnostics

✔ Check Expo config for common issues
✔ Check package.json for common issues
✔ Check native tooling versions
✔ Check dependencies for packages that should not be installed directly
✔ Check for common project setup issues
✔ Check npm/ yarn versions
✔ Check for issues with metro config
✔ Check Expo config (app.json/ app.config.js) schema
✔ Check for legacy global CLI installed locally
✔ Check that native modules do not use incompatible support packages
✔ Check that packages match versions required by installed Expo SDK
✔ Check that native modules use compatible support package versions for installed Expo SDK
@quick691fr quick691fr added the needs validation Issue needs to be validated label Mar 29, 2024
@expo-bot expo-bot added needs review Issue is ready to be reviewed by a maintainer and removed needs validation Issue needs to be validated labels Mar 29, 2024
@expo-bot
Copy link
Collaborator

expo-bot commented Apr 4, 2024

Thank you for filing this issue!
This comment acknowledges we believe this may be a bug and there’s enough information to investigate it.
However, we can’t promise any sort of timeline for resolution. We prioritize issues based on severity, breadth of impact, and alignment with our roadmap. If you’d like to help move it more quickly, you can continue to investigate it more deeply and/or you can open a pull request that fixes the cause.

@github-actions github-actions bot removed the needs review Issue is ready to be reviewed by a maintainer label Apr 4, 2024
@ngoducduy
Copy link

Any updates on this issue?

@mrakesh0608 mrakesh0608 mentioned this issue May 18, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Issue accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[video-thumbnails][Android] Fix a crash when the source cannot be retrieved mrakesh0608/expo
4 participants
@brentvatne @quick691fr @ngoducduy @expo-bot