Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zoom in & reset shortcuts are broken on experimental debugger #44595

Closed
palaniraja opened this issue May 16, 2024 · 3 comments
Closed

Zoom in & reset shortcuts are broken on experimental debugger #44595

palaniraja opened this issue May 16, 2024 · 3 comments
Assignees
Labels
Debugging DX Issues concerning how the developer experience can be improved. Resolution: Fixed A PR that fixes this issue has been merged.

Comments

@palaniraja
Copy link

Description

cmd + + to zoom in and cmd + 0 to reset zoom are broken on debugger

Steps to reproduce

start metro with --experimental-debugger new experimental debugger and try to zoom in

also npx react-native info output attached is lying.. it has Hermes enabled I can use the debugger

React Native Version

0.73.4

Affected Platforms

Runtime - Desktop

Output of npx react-native info

System:
  OS: macOS 14.4
  CPU: (10) x64 Apple M1 Pro
  Memory: 81.69 MB / 32.00 GB
  Shell:
    version: "5.9"
    path: /bin/zsh
Binaries:
  Node:
    version: 18.8.0
    path: /usr/local/bin/node
  Yarn:
    version: 1.22.22
    path: /opt/homebrew/bin/yarn
  npm:
    version: 8.18.0
    path: /usr/local/bin/npm
  Watchman:
    version: 2024.03.25.00
    path: /opt/homebrew/bin/watchman
Managers:
  CocoaPods:
    version: 1.15.2
    path: /opt/homebrew/bin/pod
SDKs:
  iOS SDK:
    Platforms:
      - DriverKit 23.2
      - iOS 17.2
      - macOS 14.2
      - tvOS 17.2
      - watchOS 10.2
  Android SDK: Not Found
IDEs:
  Android Studio: 2023.3 AI-233.14808.21.2331.11709847
  Xcode:
    version: 15.1/15C65
    path: /usr/bin/xcodebuild
Languages:
  Java:
    version: 17.0.9
    path: /usr/bin/javac
  Ruby:
    version: 2.6.10
    path: /usr/bin/ruby
npmPackages:
  "@react-native-community/cli": Not Found
  react: Not Found
  react-native: Not Found
  react-native-macos: Not Found
npmGlobalPackages:
  "*react-native*": Not Found
Android:
  hermesEnabled: Not found
  newArchEnabled: Not found
iOS:
  hermesEnabled: Not found
  newArchEnabled: Not found

Stacktrace or Logs

N/A

Reproducer

N/A

Screenshots and Videos

No response

@github-actions github-actions bot added Needs: Author Feedback Needs: Repro This issue could be improved with a clear list of steps to reproduce the issue. labels May 16, 2024
Copy link

⚠️ Missing Reproducible Example
ℹ️ We could not detect a reproducible example in your issue report. Please provide either:
  • If your bug is UI related: a Snack
  • If your bug is build/update related: use our Reproducer Template. A reproducer needs to be in a GitHub repository under your username.

Copy link

⚠️ Newer Version of React Native is Available!
ℹ️ You are on a supported minor version, but it looks like there's a newer patch available - 0.73.8. Please upgrade to the highest patch for your minor or latest and verify if the issue persists (alternatively, create a new project and repro the issue in it). If it does not repro, please let us know so we can close out this issue. This helps us ensure we are looking at issues that still exist in the most recent releases.

@huntie
Copy link
Member

huntie commented May 20, 2024

Confirmed bug. We'll see if we can resolve this — definitely in a future version of our debugger, as this remains experimental today. I'll reference this in react-native-community/discussions-and-proposals#733.

@cortinico cortinico added DX Issues concerning how the developer experience can be improved. Debugging and removed Needs: Triage 🔍 Needs: Author Feedback Needs: Repro This issue could be improved with a clear list of steps to reproduce the issue. Newer Patch Available labels May 20, 2024
@motiz88 motiz88 self-assigned this May 20, 2024
@cortinico cortinico added the Resolution: Fixed A PR that fixes this issue has been merged. label May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Debugging DX Issues concerning how the developer experience can be improved. Resolution: Fixed A PR that fixes this issue has been merged.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants