Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flutter update-packages can fail silently #148569

Open
goderbauer opened this issue May 17, 2024 · 0 comments
Open

flutter update-packages can fail silently #148569

goderbauer opened this issue May 17, 2024 · 0 comments
Assignees
Labels
P2 Important issues not at the top of the work list team-tool Owned by Flutter Tool team triaged-tool Triaged by Flutter Tool team

Comments

@goderbauer
Copy link
Member

There are probably other instances where this happens, but this is how I am able to consistently reproduce it:

  1. Clone flutter from a fork (it's important that it's cloned from a fork because those are missing tags): git clone git@github.com:goderbauer/flutter.git
  2. Run ./bin/flutter update-packages inside the cloned repository:
$./bin/flutter update-packages
Downloading Darwin arm64 Dart SDK from Flutter engine bf1c6da0dd31273405ae4107ba7225238686140b...
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  201M  100  201M    0     0  16.3M      0  0:00:12  0:00:12 --:--:-- 26.2M
Building flutter tool...
Resolving dependencies... 
Downloading packages... 
Got dependencies.
Downloading Material fonts...                                      804ms
Downloading Gradle Wrapper...                                      117ms
Downloading package sky_engine...                                  245ms
Downloading flutter_patched_sdk tools...                           321ms
Downloading flutter_patched_sdk_product tools...                   360ms
Downloading darwin-arm64 tools...                                1,253ms
Downloading libimobiledevice...                                    125ms
Downloading usbmuxd...                                             107ms
Downloading libplist...                                            111ms
Downloading openssl...                                             182ms
Downloading ios-deploy...                                          144ms
Downloading darwin-arm64/font-subset tools...                      341ms
  1. There's no indication in the output that something has failed, one has to inspect the error code to learn that the command in fact failed silently.

Expectation: It prints a clear error describing the failure so it is impossible to miss that something has gone wrong.

Currently, to learn about the real failure, one has to run the command with -v:

                    ERR : The current Flutter SDK version is 0.0.0-unknown.
                        | 
                        | Because flutter_update_packages depends on webview_flutter_wkwebview >=2.0.14 which requires Flutter SDK version >=2.5.0, version solving failed.

Speculatively, the problem of failing silently could be related to this TODO:

// TODO(ianh): If this fails, the tool exits silently.

cc @christopherfujino

@goderbauer goderbauer added the team-tool Owned by Flutter Tool team label May 17, 2024
@andrewkolos andrewkolos added P2 Important issues not at the top of the work list triaged-tool Triaged by Flutter Tool team labels May 21, 2024
@andrewkolos andrewkolos self-assigned this May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 Important issues not at the top of the work list team-tool Owned by Flutter Tool team triaged-tool Triaged by Flutter Tool team
Projects
None yet
Development

No branches or pull requests

2 participants