Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

locale in DatePickerThemeData #148202

Closed
Priyantha-Kingslake opened this issue May 13, 2024 · 0 comments · Fixed by #148292
Closed

locale in DatePickerThemeData #148202

Priyantha-Kingslake opened this issue May 13, 2024 · 0 comments · Fixed by #148292
Labels
a: internationalization Supporting other languages or locales. (aka i18n) c: new feature Nothing broken; request for a new capability c: proposal A detailed proposal for a change to Flutter f: date/time picker Date or time picker widgets f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. P3 Issues that are less important to the Flutter project team-design Owned by Design Languages team triaged-design Triaged by Design Languages team waiting for PR to land (fixed) A fix is in flight

Comments

@Priyantha-Kingslake
Copy link

Use case

when using showDatePicker we have the option to set locale

showDatePicker(
  locale: Locale('en'),
  ...

But when we have multiple of this widget across our app setting this locale individually is cumbersome and feels against best practices.
We do have a class to set the global theme DatePickerThemeData, but this class does not support locale.

Proposal

Include locale property in DatePickerThemeData so that we may globaly set the locale for showDatePicker.
@danagbemava-nc danagbemava-nc added in triage Presently being triaged by the triage team framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. f: date/time picker Date or time picker widgets a: internationalization Supporting other languages or locales. (aka i18n) c: proposal A detailed proposal for a change to Flutter team-design Owned by Design Languages team and removed in triage Presently being triaged by the triage team labels May 13, 2024
@MajdSallora MajdSallora mentioned this issue May 14, 2024
Merged
9 tasks
@Piinks Piinks added waiting for PR to land (fixed) A fix is in flight triaged-design Triaged by Design Languages team P3 Issues that are less important to the Flutter project c: new feature Nothing broken; request for a new capability labels May 15, 2024
@chinmoy12c chinmoy12c mentioned this issue May 18, 2024
Closed
9 tasks
@auto-submit auto-submit bot closed this as completed in df95cb2 May 30, 2024
victorsanni pushed a commit to victorsanni/flutter that referenced this issue May 31, 2024
@MajdSallora @victorsanni
Add locale in DatePickerThemeData (flutter#148292)
4d588e2 
*This PR changes the date picker were add locale in DatePickerThemeData*

*List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.*
Fixes flutter#148202 

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a: internationalization Supporting other languages or locales. (aka i18n) c: new feature Nothing broken; request for a new capability c: proposal A detailed proposal for a change to Flutter f: date/time picker Date or time picker widgets f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. P3 Issues that are less important to the Flutter project team-design Owned by Design Languages team triaged-design Triaged by Design Languages team waiting for PR to land (fixed) A fix is in flight
Projects
None yet
Milestone
No milestone
3 participants
@Piinks @danagbemava-nc @Priyantha-Kingslake