Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate test code from lib389 #3082

Open
389-ds-bot opened this issue Sep 13, 2020 · 5 comments · May be fixed by #5212
Open

Separate test code from lib389 #3082

389-ds-bot opened this issue Sep 13, 2020 · 5 comments · May be fixed by #5212
Labels
lib389 Involves lib389 librabry
Milestone
2.0.0

Comments

@389-ds-bot
Copy link

Cloned from Pagure issue: https://pagure.io/389-ds-base/issue/50023

Issue Description

topologies module is used only in tests. But because it's part of lib389, it pulls in pytest and its dependencies. Additionally, lib389 contains tests that are installed, but not needed for lib389 to function:

$ find /usr/lib/python3.7/site-packages/lib389/tests/ -type f  | wc -l
207
@389-ds-bot 389-ds-bot added the lib389 Involves lib389 librabry label Sep 13, 2020
@389-ds-bot 389-ds-bot added this to the 1.4 backlog milestone Sep 13, 2020
@389-ds-bot
Copy link
Author

Comment from vashirov (@vashirov) at 2018-11-12 17:57:57

Metadata Update from @vashirov:

  • Custom field component adjusted to None
  • Custom field origin adjusted to None
  • Custom field reviewstatus adjusted to None
  • Custom field type adjusted to None
  • Custom field version adjusted to None
  • Issue tagged with: lib389

@389-ds-bot
Copy link
Author

Comment from mreynolds (@mreynolds389) at 2018-11-15 17:52:37

Metadata Update from @mreynolds389:

  • Issue set to the milestone: 1.4.0

@389-ds-bot
Copy link
Author

Comment from vashirov (@vashirov) at 2018-12-12 17:09:22

Metadata Update from @vashirov:

  • Issue assigned to vashirov

@389-ds-bot
Copy link
Author

Comment from mreynolds (@mreynolds389) at 2020-02-12 16:45:47

Metadata Update from @mreynolds389:

  • Issue priority set to: minor
  • Issue set to the milestone: 1.4 backlog (was: 1.4.0)

@mreynolds389 mreynolds389 modified the milestones: 1.4 backlog, 2.0.0 Nov 18, 2020
stanislavlevin added a commit to stanislavlevin/389-ds-base that referenced this issue Mar 16, 2022
@stanislavlevin
Issue 3082 - Separate test code from lib389
43aa023 
Bug Description:
`topologies` module is used only in tests. But because it's part of
lib389, it pulls in pytest and its dependencies. Additionally, lib389
contains tests that are installed, but not needed for lib389 to
function.

`perftools` module is also used only for tests and depends on
`topologies`.

Fix Description:
`topologies` and `perftools` modules have been converted into Python
packages.

Fixes: 389ds#3082

Reviewed by:

Signed-off-by: Stanislav Levin <slev@altlinux.org>
@stanislavlevin stanislavlevin linked a pull request Mar 16, 2022 that will close this issue
Open
@progier389 progier389 mentioned this issue Sep 8, 2023
Merged
@progier389
Copy link
Contributor

As said in issue #5924, IMHO while removing lib389 dependency over pytest we should also redesign the topology framework:
We should have a single lib389 function that should be able to specify the current options plus
any template parameters , and options to add entries or replace values in the dse.ldif before starting the instance
the the topology code that should be moved in the test framework could rely on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
lib389 Involves lib389 librabry
Projects
None yet
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

Issue 3082 - Separate test code from lib389 stanislavlevin/389-ds-base
3 participants
@mreynolds389 @389-ds-bot @progier389