Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue in forceFitColumns option #248

Closed
nzhtrtlc opened this issue May 31, 2018 · 9 comments
Closed

Issue in forceFitColumns option #248

nzhtrtlc opened this issue May 31, 2018 · 9 comments

Comments

@nzhtrtlc
Copy link

Hi, there is an issue in forceFitColumns option or this.grid.autoSizeColumns();
In my grid which have lot of columns i want to fit my columns but there is an style issue about it.
Here is the screen record for you https://drive.google.com/file/d/1zuYPKvU02OFepvjeS5fvoJh3G0BG2Iep/view

I have no problem with less columns, but with lot of columns it brokes like in video.

@6pac
Copy link
Owner

6pac commented May 31, 2018

Could you try reproducing this on the Simplest Example. Start with that, increase the number of columns and apply the flag. As minimal changes as possible to repro the problem.

You can attach the result to your next issue post, and I'll add it to the repo in the Test folder, or the Example folder if this turns out to be a configuration issue that needs more demonstration.
This way we can both work on a shared file.

@nzhtrtlc
Copy link
Author

nzhtrtlc commented Jun 1, 2018

@6pac You are right the problem is in my own code. My grid is in my own tab component
(i am usign react) When i take my grid out of the tab component it works great but when i put it back to tab component it brokes as in the video record. I have no idea why is happening :(

@ghiscoding
Copy link
Collaborator

Could that be a problem because of #239 ?

@6pac
Copy link
Owner

6pac commented Jun 2, 2018

It's not throwing any errors in the console? If it was #239, could the issue still occur if there was no dragging and dropping attempted in the repro? I'm assuming overriding the events could cause errors, but they'd presumably be visible as an indicator.

@ghiscoding
Copy link
Collaborator

not necessarily, I think in the sample I provided it just change the behavior

@6pac
Copy link
Owner

6pac commented Jun 4, 2018

I think reworking SlickGrid to remove the jQuery drag and drop dependencies is a great idea. HOWEVER, articles like this one scare the hell out of me. Seems no-one has posted much about native browser HTML5 Drag and Drop since 2010 - there's a lot of talk from that year (eg. here, here and more recent but less complete here ), but I can't find anywhere where someone has said 'this is all resolved now'. So I'm forced to conclude that we're opening a big time can of worms trying to do that - and that's what the contributor who originally tried and failed to do it said: see #14 #15

@nzhtrtlc
Copy link
Author

nzhtrtlc commented Jun 6, 2018

@6pac No its not throwing any errors in console. I removed that option then i gave manuel width instead of autoSize option. This is how i solve the problem for now.

@6pac
Copy link
Owner

6pac commented Jun 6, 2018

OK @nzhtrtlc, I think that's the best for now. @ghiscoding is right, this problem may be solved on a different branch, I've just got to check it out and work out how that fits in with the main repo.

@ghiscoding
Copy link
Collaborator

Since this issue was opened in 2018, the entire structure of the project changed, we removed jQuery/jQueryUI and now use SortableJS for dragging column (we had to find a replacement for jQueryUI drag and SortableJS was what we chose). We also recently migrated to TypeScript so the a lot of the original code got reworked.

I think it's best to close this issue since it is very out of date with our new structure, please add more details if you think this is still an issue with latest code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants