Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort out state size check logics #3387

Open
gldeng opened this issue Mar 21, 2023 · 0 comments
Open

Sort out state size check logics #3387

gldeng opened this issue Mar 21, 2023 · 0 comments

Comments

@gldeng
Copy link
Contributor

gldeng commented Mar 21, 2023

In StateWrittenInstructionInjector we have an implicit requirement for injecting the ValidateStateSize call. It requires to access the Context which is a field in CSharpSmartContractAbstract, hence only is possible in a smart contract.

In CodeCheck, currently we do this check in InstructionInjectionValidator, which means the logics are scattered in two places. We need to fix it. One option is to remove StateWrittenInstructionInjector and put all logics in InstructionInjectionValidator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant