Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Streamline build time code checks and code patching #3389

Open
gldeng opened this issue Mar 24, 2023 · 0 comments
Open

Streamline build time code checks and code patching #3389

gldeng opened this issue Mar 24, 2023 · 0 comments

Comments

@gldeng
Copy link
Contributor

gldeng commented Mar 24, 2023

May be we need to add three tasks in building phase:

  1. Pre-patch code check
  2. Patch
  3. Post-patch code check

So in patch step, we assume the code has already been code-checked.

Note: Maybe we should reference how MsBuild performs compilation to see if there are any similar tasks of the same nature so that we can follow.
@gldeng gldeng changed the title Patcher should fail if code doesn't satisfy pre-patch code checks Streamline build time code checks and code patching Mar 24, 2023
@gldeng gldeng mentioned this issue Mar 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gldeng